Skip to content

Add note about extracting RTI provided openssl#664

Merged
sloretz merged 2 commits intomasterfrom
sloretz/rti_openssl_extract
May 8, 2020
Merged

Add note about extracting RTI provided openssl#664
sloretz merged 2 commits intomasterfrom
sloretz/rti_openssl_extract

Conversation

@sloretz
Copy link
Contributor

@sloretz sloretz commented May 7, 2020

Relates to #662

@sloretz sloretz self-assigned this May 7, 2020
@mjcarroll mjcarroll temporarily deployed to ros2-documentation-pr-664 May 7, 2020 19:31 Inactive
@mikaelarguedas
Copy link
Member

I recommend not merging this.

This is a duplicate of the information in the paragraph above and gives the wrong impression that RTI_OPENSSL_{LIBS,BIN} are used anywhere outside the test_security package.

The actual thing to do depends on the platform, it can be adding things to PATH, LD_LIBRARY_PATH, DYLD_LIBRARY_PATH ...

I would recommend removing that section and link people to official RTI documentation instead https://community.rti.com/static/documentation/connext-dds/5.3.1/doc/manuals/connext_dds/dds_security/RTI_SecurityPlugins_GettingStarted.pdf

@jacobperron
Copy link
Member

I agree that this PR doesn't seem necessary.

@sloretz
Copy link
Contributor Author

sloretz commented May 8, 2020

I recommend not merging this [...] I would recommend removing that section and link people to official RTI documentation instead

Roger. PR is now just adding a link to RTI's documentation.

@sloretz sloretz merged commit 911000c into master May 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the sloretz/rti_openssl_extract branch May 8, 2020 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants