Extract imports out from __init__() and __type_support__()#237
Open
InvincibleRMC wants to merge 3 commits intoros2:rollingfrom
Open
Extract imports out from __init__() and __type_support__()#237InvincibleRMC wants to merge 3 commits intoros2:rollingfrom
__init__() and __type_support__()#237InvincibleRMC wants to merge 3 commits intoros2:rollingfrom
Conversation
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For about a
5%speed up in message construction times and simplification of importing logic by moving imports out of__init__()and__type_support__().All part of a grand plan to maybe support
OptionalIdl types by further simplify the__init__()method.Is this user-facing behavior change?
No only internals should change.
Did you use Generative AI?
Additional Information