Make :username optional configuration argument#7
Merged
rosenfeld merged 1 commit intorosenfeld:masterfrom Oct 24, 2022
Merged
Conversation
When developing locally on Postgres and SQLite, it's common to rely on the default username and have no password, which happens when creating the database with `createdb mydatabase`. So, it would be convenient not to have to pass the username. It seems that the database URL generator is already handling the scenario of `:username` being `nil`.
Owner
|
I have no idea why it was required before. Merged, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When developing locally on Postgres and SQLite, it's common to rely on the default username and have no password, which happens when we create the database with
createdb mydatabaseon Postgres (on SQLite it's the norm). So, it would be convenient not to have to pass the username. It seems that the database URL generator is already handling the scenario of:usernamebeingnil.This was extracted from #5.