This repository was archived by the owner on Jul 8, 2024. It is now read-only.
Don't suggest adding fbauth to the application's query schemes#293
Open
tp wants to merge 1 commit intoroughike:masterfrom
Open
Don't suggest adding fbauth to the application's query schemes#293tp wants to merge 1 commit intoroughike:masterfrom
fbauth to the application's query schemes#293tp wants to merge 1 commit intoroughike:masterfrom
Conversation
This fixes the redirect loop between the Safari ViewController (SFVC) and the Facebook app mentioned in roughike#243 After that scheme is removed, the FB SDK seems to build another URL to open in the web view, which doesn't show a button to open the native FB app anymore. Hence the user just proceeds inside the SFVC with their account, and will be directed straight back to the host app, never taking a "detour" to the FB app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the redirect loop between the Safari ViewController (SFVC) and the Facebook app mentioned in #243
After that scheme is removed, the FB SDK seems to build another URL to open in the web view, which doesn't show a button to open the native FB app anymore.
Hence the user just proceeds inside the SFVC with their account, and will be directed straight back to the host app, never taking a "detour" to the FB app.