Open
Conversation
mgirlich
commented
Oct 17, 2023
| SEXP new_tag(SEXP tagName, SEXP varArgs, SEXP noWS, SEXP renderHook) { | ||
| R_xlen_t n = Rf_xlength(varArgs); | ||
|
|
||
| // TODO validate that varArgs is a list |
Author
There was a problem hiding this comment.
It is documented that varArgs must be a list but there is a test where this is not the case. Should we allow varArgs to be e.g. a character and simply wrap it in a list?
mgirlich
commented
Oct 17, 2023
| }) | ||
|
|
||
| test_that("tag with noWS works",{ | ||
| skip("should tag accept only lists?") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #414.
I think it is worth implementing
tag()in C to make it fast. Especially when usingtag()directly instead oftags$...this is now quite fast.