Add new sass_html_dependencies() function for more convenient htmlDependency bundling #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
commented
Sep 2, 2020
| @@ -0,0 +1,58 @@ | |||
| #' Compile Sass to CSS using LibSass, then return an HTML Dependencies | |||
| #' | |||
| #' Calls `sass(input, ...)` and wraps the output into a [htmltools::htmlDependency()]. | |||
Contributor
Author
There was a problem hiding this comment.
Suggested change
| #' Calls `sass(input, ...)` and wraps the output into a [htmltools::htmlDependency()]. | |
| #' Calls `sass(input, ...)` and wraps the output into a list of [htmltools::htmlDependency()]s. |
wch
reviewed
Sep 3, 2020
wch
reviewed
Sep 3, 2020
wch
reviewed
Sep 3, 2020
wch
reviewed
Sep 3, 2020
| #' stylesheet = "my-style.css" | ||
| #' )) | ||
| sass_html_dependencies <- function( | ||
| input, name, version, stylesheet, cache_key = NULL, |
Collaborator
There was a problem hiding this comment.
It's kind of confusing how the htmlDependency args are interleaved with the sass args, and that the order of the htmlDependency args aren't even the same as in the htmlDependency function.
One possibility: maybe all of the htmlDependency args should go after ...? We can also discuss other ways to go about this.
cpsievert
force-pushed
the
sass_dependencies
branch
from
ae3a082 to
7dd9962
Compare
Contributor
Author
|
Update: this idea might be worth returning to if we decide to return to the idea of "run-time" html dependencies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.