Security-fix: GoDAM integration #2274
Merged
+99
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an Insecure Direct Object Reference (IDOR) vulnerability in the Godam integration by adding proper authentication and authorization checks to the AJAX endpoint that loads activity comment HTML.
Changes:
- Removed unauthenticated access to the
get_single_activity_comment_htmlAJAX endpoint - Added explicit authentication and permission verification before returning activity data
- Implemented a comprehensive permission checking function that handles groups, profiles, and other activity components
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
NoumaanAhamed
changed the title
mi5t4n
reviewed
Jan 21, 2026
mi5t4n
reviewed
Jan 21, 2026
| * | ||
| * @return bool True if the user can view the activity, false otherwise. | ||
| */ | ||
| function godam_user_can_view_activity( $activity ) { |
Member
There was a problem hiding this comment.
Since, this is a rtMedia plugin, let's not use godam prefix for the function as it's being used by GoDAM plugin. Use the correct prefix used by rest of the rtMedia functions.
Contributor
|
Unable to PHPCS or SVG scan one or more files due to error running PHPCS/SVG scanner:
The error may be temporary. If the error persists, please contact a human (commit-ID: 270596a). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue at https://github.com/rtCamp/godam-core/issues/744