Skip to content

Fix: translations loading earlier warning #2275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NoumaanAhamed merged 2 commits into from
Jan 30, 2026
+9 −2
Merged

Fix: translations loading earlier warning #2275

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
beb8a54
Merge pull request #2262 from rtCamp/develop
Pradeep1308 Jan 6, 2026
4cdafb3
fix: load translations at the init action
NoumaanAhamed Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions app/admin/RTMediaUploadTermsAdmin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,22 @@ class RTMediaUploadTermsAdmin {
* Constructing settings for upload terms.
*/
public function __construct() {
$this->upload_terms_message = esc_html__( 'terms of services.', 'buddypress-media' );
$this->upload_terms_error_message = esc_html__( 'Please check terms of service.', 'buddypress-media' );
add_action( 'init', array( $this, 'init_translations' ), 5 );

add_action( 'admin_enqueue_scripts', array( $this, 'enqueue_scripts_styles' ), 999 );
add_filter( 'rtmedia_general_content_default_values', array( $this, 'add_admin_option_default_value' ), 10, 1 );
add_filter( 'rtmedia_general_content_groups', array( $this, 'admin_setting_add_terms_section' ), 10, 1 );
add_filter( 'rtmedia_general_content_add_itmes', array( $this, 'admin_setting_add_terms_option' ), 10, 2 );
}

/**
* Initialize translations at the proper time.
*/
public function init_translations() {
$this->upload_terms_message = esc_html__( 'terms of services.', 'buddypress-media' );
$this->upload_terms_error_message = esc_html__( 'Please check terms of service.', 'buddypress-media' );
}

/**
* Loads styles and scripts
*
Expand Down
Loading