Skip to content

security: escape media title in MediaView to prevent XSS #2287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vamsi0702 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

security: escape media title in MediaView to prevent XSS #2287

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11de618
security: escape media title in MediaView to prevent XSS
Vamsi0702 Jan 30, 2026
5059304
Merge branch 'rtCamp:develop' into fix/security-issue-2240
Vamsi0702 Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions app/assets/js/rtMedia.backbone.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,12 @@ jQuery(function ($) {
this.render();
},
render: function () {
$(this.el).html(this.template(this.model.toJSON()));
var data = this.model.toJSON();
// High-Quality Fix: Escape the media title to prevent XSS
if (data.media_title) {
data.media_title = rtm_escape_html(data.media_title);
}
$(this.el).html(this.template(data));
return this.el;
},
unrender: function () {
Expand Down Expand Up @@ -1483,7 +1488,7 @@ jQuery(document).ready(function ($) {
/**
* Commented by : Naveen giri
* Reason : Commenting this code because its overriding buddypress functionality
* and introducing issue Duplicate activity generation Issue #108.
* and introducing issue Duplicate activity generation Issue #108.
*/
/*JQuery( '#aw-whats-new-submit' ).removeAttr( 'disabled' );
jQuery( document ).on( 'blur', '#whats-new', function() {
Expand Down Expand Up @@ -3679,7 +3684,7 @@ function rtmedia_disable_popup_navigation($selector) {

/**
* Function that smooth scrolls to the latest comment in rtMedia.
* Created on 23-Nov-2020 by Vipin Kumar Dinkar <vipin.dinkar@rtcamp.com>
* Created on 23-Nov-2020 by Vipin Kumar Dinkar <vipin.dinkar@rtcamp.com>
*/
const rtMediaScrollComments = () => {
const commentBox = document.getElementById("rtmedia_comment_ul");
Expand All @@ -3703,4 +3708,4 @@ const rtMediaMaxSizeMessage = () => {
}
};

rtMediaMaxSizeMessage();
rtMediaMaxSizeMessage();