Draft
Conversation
When the current branch tracks an upstream branch, generate a link to that upstream branch (or SHA) rather than using the local one, since it may not exist upstream. In the case that the local branch has no upstream, prompt the user for the branch name to generate a link for. Partly addresses ruanyl#10. Co-authored-by: souldzin <souldzin@souldzin.com>
Author
|
@souldzin and I worked on this last week. It's preliminary, e.g., there are no additional tests for this, hence the draft status. The main goal was to avoid generating a 404 link in the case that the current HEAD commit doesn't exist on the remote (which, for me, is the case the majority of the time). Some other possible approaches that might be better:
I'd really appreciate any thoughts on how to carry this forward! 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the current branch tracks an upstream branch, generate a link to
that upstream branch (or SHA) rather than using the local one, since it
may not exist upstream.
In the case that the local branch has no upstream, prompt the user for
the branch name to generate a link for.
Partly addresses #10.
Co-authored-by: souldzin souldzin@souldzin.com