Skip to content

Skip flaky webauthn test on TruffleRuby #9370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hsbt merged 1 commit into from
Mar 6, 2026
Merged

Skip flaky webauthn test on TruffleRuby #9370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/rubygems/test_gem_commands_push_command.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,6 +487,7 @@ def test_with_webauthn_enabled_success
end

def test_with_webauthn_enabled_failure
pend "Flaky on TruffleRuby" if RUBY_ENGINE == "truffleruby"
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description links to #9352 and includes details about replacing Psych with a pure-Ruby YAML parser, but this change only adds a TruffleRuby pending guard for a WebAuthn push command test. Please update the PR description to reference the correct upstream change/issue for this flakiness (or remove the unrelated referenced PR content) so the rationale is traceable.

Copilot uses AI. Check for mistakes.
response_success = "Successfully registered gem: freewill (1.0.0)"
server = Gem::MockTCPServer.new
error = Gem::WebauthnVerificationError.new("Something went wrong")
Expand Down