Remove dead code in dependency installer tests#9371
Merged
Conversation
Remove unused si.to_yaml calls that stored YAML at URLs that were never fetched. With the pure-Ruby parser, NilClass no longer has to_yaml, but these lines were dead code regardless.
Contributor
There was a problem hiding this comment.
Pull request overview
Removes unused YAML-related setup from Gem::DependencyInstaller tests, aligning the test suite with current util_setup_spec_fetcher behavior and eliminating redundant @fetcher stubbing.
Changes:
- Drop unused local variable assignments capturing
util_setup_spec_fetcher’s return value. - Remove dead stubbing of
@fetcher.data["http://gems.example.com/gems/yaml"]in two tests.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
hsbt
added a commit
that referenced
this pull request
Mar 10, 2026
Remove dead code in dependency installer tests (cherry picked from commit 884d80f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #9352