Make SafeYAML.load an alias of safe_load#9391
Merged
hsbt merged 5 commits intoruby:masterfrom Mar 12, 2026
Merged
Conversation
This was changed to unsafe_load with the swap to YAMLSerializer. But this method did not previously do an unsafe load and we shouldn't provide that.
This had been the only user of Gem::SafeYAML.load for a long time. We might as well be consistent with all other uses and use safe_load.
Using Psych, load was actually more restrictive than safe_load. Using Gem::YAMLSerializer they were identical. We might as well use the same path for both methods.
jhawthorn
force-pushed
the
fix_safe_yaml_load
branch
from
a2074cd to
d8d927f
Compare
hsbt
approved these changes
Mar 12, 2026
Member
hsbt
left a comment
hsbt
left a comment
There was a problem hiding this comment.
Thanks! That maked sense to me. We should introduce safe_load only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #9352, when using Psych,
SafeYAML.loadwas changed toPsych.unsafe_load, which we should not be using at all.Looking into this a little more, I don't think we need a
SafeYAML.load. It was already safe (more restrictive thansafe_load, other than maybe allowing more symbols?). The only user we had was owner_command, which probably should have been usingsafe_load.I made this in separate commits, so feel free to cherry-pick or squash if not all of this is desirable. Only the first is essential to remove
unsafe_load, the rest is cleanup.cc @hsbt