Add tool to verify YAMLSerializer can load gemspecs of popular gems and their dependencies#9398
Closed
Add tool to verify YAMLSerializer can load gemspecs of popular gems and their dependencies#9398
YAMLSerializer can load gemspecs of popular gems and their dependencies#9398Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new RubyGems tooling script to sanity-check that Gem::YAMLSerializer can parse real-world gemspec YAML by downloading gem files for a set of popular gems and their transitive runtime dependencies.
Changes:
- Introduce
tool/test_yaml_serializer_with_popular_gems.rbto fetch top-N gems, resolve runtime dependency closure, download.gemfiles, and runGem::YAMLSerializer.loadon their gemspec metadata.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
4 tasks
…nd their dependencies Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… tool Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
I verified Top 1000 download gems and 404 transitive dependencies. The only gem whose gemspec could not be parsed was the escape gem. I fixed that at #9399 |
Member
Author
|
After thinking about it overnight, this script doesn't need to be included in the repository. So I'm closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
from #9352 (comment)
I've tested to load gemspec of popular gems and their dependencies with
YAMLSerializer.What is your fix for the problem, implemented in this PR?
This scripts download and load 773 gems from 300 top downloads.
YAMLSerializercould load them.You can test that with:
I'm not sure how much testing is needed before it becomes practical, but I want to continue testing.
Make sure the following tasks are checked