Extract host and port from Host header for CONNECT and OPTIONS * requests.#182
Merged
ioquatix merged 2 commits intoruby:masterfrom Dec 5, 2025
Merged
Conversation
…ests Previously, CONNECT and OPTIONS * requests returned early from parse() before extracting host and port from the Host header. This caused meta_vars to return nil for SERVER_NAME and empty string for SERVER_PORT, breaking CGI variable generation for these request types. This change: - Extracts the host/port logic into a new extract_host_port method - Calls setup_forwarded_info and extract_host_port for CONNECT/OPTIONS * - Refactors parse_uri to use extract_host_port internally - Adds tests for OPTIONS * requests with Host header
jeremyevans
approved these changes
Dec 5, 2025
Contributor
jeremyevans
left a comment
jeremyevans
left a comment
There was a problem hiding this comment.
Looks good. Only changes I suggest are not issues with this PR, but existing issues with the code.
Co-authored-by: Jeremy Evans <code@jeremyevans.net>
Member
|
Thanks @jeremyevans |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
CONNECTandOPTIONS *requests returned early from parse() before extracting host and port from theHostheader. This caused meta_vars to return nil forSERVER_NAMEand empty string forSERVER_PORT, breaking CGI variable generation for these request types.This change:
setup_forwarded_infoandextract_host_portforCONNECT/OPTIONS *.parse_urito useextract_host_port internally.OPTIONS *requests with Host header.