fix!: Big move to use kwargs as the initializer for classes which include us#28
Merged
fix!: Big move to use kwargs as the initializer for classes which include us#28
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR changes the way class initialization is handled in the NatsApiServer module, migrating from positional arguments to keyword arguments. The changes ensure that classes including the module must use keyword arguments in their initializers, providing better clarity and type safety.
- Adds validation to ensure
instance_argsis a Hash when provided - Updates the worker instantiation to use keyword argument splat (
**) instead of positional argument splat (*) - Refactors parameter handling in
build_workermethod for consistency
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/leopard/nats_api_server.rb | Adds Hash validation for instance_args and updates worker instantiation to use keyword arguments |
| lib/leopard/message_wrapper.rb | Adds header assignment in respond method |
| examples/echo_endpoint.rb | Updates example to use keyword arguments and includes debugging code |
afulki
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully this doesn't break anything yet, but after
discussing with @BryceARich I changed the way we assume
a class which includes us will define its initializer.
Before we were mandating a simple array of arguments,
this PR will mandate kwargs (Keyword Arguments) only
and raise and ArgumentError in #run if instance_args:
which are not a hash are passed to it.