implement hw 1 by ivkarpechenko · Pull Request #761 · rubyroidlabs/bsuir-courses

ivkarpechenko · 2018-02-18T16:42:04Z

Фамилия Имя

Карпеченко Иван

Email

ivkarpechenko@gmail.com

Номер домашнего задания

1

Ссылка на видео с демо работы

https://www.youtube.com/watch?v=Kcgrlq_8YaY

+   |elem| str += elem.to_s.rjust(number_max_len, '0') + (gaps + "  ")
+  end
+  puts "#{" " * three_len.to_s.length}" + (help_str * i).chomp(gaps).center(console_len) #ветви
+  puts "#{i.to_s.rjust(three_len.to_s.length, '0')}" + str.chomp(gaps + "  ").center(console_len, ",") #элементы


Prefer to_s over string interpolation.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Line is too long. [112/80]
Missing space after #.
Use only ascii symbols in comments.

houndci-bot · 2018-02-18T16:42:14Z

2018/IvanKarpechanka/1/hw.rb

+  pascals_row(i, first_el).each do
+   |elem| str += elem.to_s.rjust(number_max_len, '0') + (gaps + "  ")
+  end
+  puts "#{" " * three_len.to_s.length}" + (help_str * i).chomp(gaps).center(console_len) #ветви


Prefer to_s over string interpolation.
Prefer single-quoted strings inside interpolations.
Line is too long. [95/80]
Missing space after #.
Use only ascii symbols in comments.

houndci-bot · 2018-02-18T16:42:14Z

2018/IvanKarpechanka/1/hw.rb

+(0..three_len).each do |i| 
+  str = "" #для создания строки вывода на консоль каждой строчки дерева
+  pascals_row(i, first_el).each do
+   |elem| str += elem.to_s.rjust(number_max_len, '0') + (gaps + "  ")


Block argument expression is not on the same line as the block start.
Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2018-02-18T16:42:14Z

2018/IvanKarpechanka/1/hw.rb

+gaps = (" " * (number_max_len)) #для формирования отображения в консоле
+help_str = "\/#{gaps}\\#{gaps}" #задание шаблона отображения ветвей дерева
+(0..three_len).each do |i| 
+  str = "" #для создания строки вывода на консоль каждой строчки дерева


Prefer single-quoted strings when you don't need string interpolation or special symbols.
Missing space after #.
Use only ascii symbols in comments.

houndci-bot · 2018-02-18T16:42:15Z

2018/IvanKarpechanka/1/hw.rb

+puts "Введите базовый номер:"
+first_el = gets.chomp.to_i
+
+number_max_len = pascals_row(three_len, first_el).max.to_s.length #для вывода числа с нулями в начале, если его длинна меньше длинны максимального элемента


Missing space after #.
Use only ascii symbols in comments.
Line is too long. [155/80]

houndci-bot · 2018-02-18T16:42:15Z

2018/IvanKarpechanka/1/hw.rb

+
+puts "Введите глубину дерева:"
+three_len = gets.chomp.to_i
+puts "Введите базовый номер:"


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2018-02-18T16:42:15Z

2018/IvanKarpechanka/1/hw.rb

+  (0..row).map { |line| first_el * binom(row, line) }
+end
+
+puts "Введите глубину дерева:"


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2018-02-18T16:42:15Z

2018/IvanKarpechanka/1/hw.rb

+end
+
+def binom(n,k)
+  fact(n) / ( fact(k) * fact(n-k) )


Space inside parentheses detected.
Surrounding space missing for operator -.

houndci-bot · 2018-02-18T16:42:15Z

2018/IvanKarpechanka/1/hw.rb

+  (1..n).inject(1, :*)
+end
+
+def binom(n,k)


Space missing after comma.

houndci-bot · 2018-02-18T17:10:26Z

2018/IvanKarpechanka/1/hw.rb

+  end
+  puts "#{' ' * three_len.to_s.length}" + (help_str * i).chomp(gaps).center(console_len)
+  puts "#{i.to_s.rjust(three_len.to_s.length, '0')}" + str.chomp(gaps + '  ').center(console_len, ',')
+end


Final newline missing.

houndci-bot · 2018-02-18T17:10:26Z

2018/IvanKarpechanka/1/hw.rb

+   str += elem.to_s.rjust(number_max_len, '0') + (gaps + '  ')
+  end
+  puts "#{' ' * three_len.to_s.length}" + (help_str * i).chomp(gaps).center(console_len)
+  puts "#{i.to_s.rjust(three_len.to_s.length, '0')}" + str.chomp(gaps + '  ').center(console_len, ',')


Prefer to_s over string interpolation.
Line is too long. [102/80]

houndci-bot · 2018-02-18T17:10:26Z

2018/IvanKarpechanka/1/hw.rb

+  pascals_row(i, first_el).each do |elem|
+   str += elem.to_s.rjust(number_max_len, '0') + (gaps + '  ')
+  end
+  puts "#{' ' * three_len.to_s.length}" + (help_str * i).chomp(gaps).center(console_len)


Prefer to_s over string interpolation.
Line is too long. [88/80]

houndci-bot · 2018-02-18T17:10:26Z

2018/IvanKarpechanka/1/hw.rb

+(0..three_len).each do |i|
+  str = '' # to create an output line on the console of each line of the tree
+  pascals_row(i, first_el).each do |elem|
+   str += elem.to_s.rjust(number_max_len, '0') + (gaps + '  ')


Use 2 (not 1) spaces for indentation.

houndci-bot · 2018-02-18T17:10:26Z

2018/IvanKarpechanka/1/hw.rb

+# to output a number with zeros in the beginning if its length is less than the length of the maximum element
+number_max_len = pascals_row(three_len, first_el).max.to_s.length
+console_len = 160
+gaps = (' ' * (number_max_len))


Don't use parentheses around a variable.

houndci-bot · 2018-02-18T17:10:26Z

2018/IvanKarpechanka/1/hw.rb

+puts 'Введите базовый номер:'
+first_el = gets.chomp.to_i
+
+# to output a number with zeros in the beginning if its length is less than the length of the maximum element


Line is too long. [109/80]

houndci-bot · 2018-02-18T17:17:00Z

2018/IvanKarpechanka/1/hw.rb

+  help1 = "#{' ' * three_len.to_s.length}"
+  puts  help1 + (help_str * i).chomp(gaps).center(console_len)
+
+  help2 = "#{i.to_s.rjust(three_len.to_s.length, '0')}"


Prefer to_s over string interpolation.

houndci-bot · 2018-02-18T17:17:00Z

2018/IvanKarpechanka/1/hw.rb

+(0..three_len).each do |i|
+  str = '' # to create an output line on the console of each line of the tree
+  pascals_row(i, first_el).each do |elem|
+  	str += elem.to_s.rjust(number_max_len, '0') + (gaps + '  ')


Use 2 (not 1) spaces for indentation.
Tab detected.

houndci-bot · 2018-02-18T17:17:00Z

2018/IvanKarpechanka/1/hw.rb

+puts 'Введите базовый номер:'
+first_el = gets.chomp.to_i
+
+# to output a number with zeros in the beginning if its 


Trailing whitespace detected.

houndci-bot · 2018-02-18T20:05:34Z

2018/IvanKarpechanka/1/hw.rb

+  help1 = ' ' * three_len.to_s.length
+  puts help1 + (help_str * i).chomp(gaps).center(console_len)
+  help2 = i.to_s.rjust(three_len.to_s.length, '0')
+  puts help2 + str.chomp(gaps + '  ').center(console_len, ',')


Inconsistent indentation detected.

houndci-bot · 2018-02-18T20:05:34Z

2018/IvanKarpechanka/1/hw.rb

+  end
+  help1 = ' ' * three_len.to_s.length
+  puts help1 + (help_str * i).chomp(gaps).center(console_len)
+  help2 = i.to_s.rjust(three_len.to_s.length, '0')


Inconsistent indentation detected.

houndci-bot · 2018-02-18T20:05:34Z

2018/IvanKarpechanka/1/hw.rb

+  	str += elem.to_s.rjust(number_max_len, '0') + (gaps + '  ')
+  end
+  help1 = ' ' * three_len.to_s.length
+  puts help1 + (help_str * i).chomp(gaps).center(console_len)


Inconsistent indentation detected.

houndci-bot · 2018-02-18T20:05:34Z

2018/IvanKarpechanka/1/hw.rb

+  pascals_row(i, first_el).each do |elem|
+  	str += elem.to_s.rjust(number_max_len, '0') + (gaps + '  ')
+  end
+  help1 = ' ' * three_len.to_s.length


Inconsistent indentation detected.

houndci-bot · 2018-02-18T20:05:34Z

2018/IvanKarpechanka/1/hw.rb

+(0..three_len).each do |i|
+	str = '' # to create an output line on the console of each line of the tree
+  pascals_row(i, first_el).each do |elem|
+  	str += elem.to_s.rjust(number_max_len, '0') + (gaps + '  ')


Use 2 (not 1) spaces for indentation.
Tab detected.

houndci-bot · 2018-02-18T20:05:34Z

2018/IvanKarpechanka/1/hw.rb

+help_str = "\/#{gaps}\\#{gaps}" # Specifying a Tree Display Template
+(0..three_len).each do |i|
+	str = '' # to create an output line on the console of each line of the tree
+  pascals_row(i, first_el).each do |elem|


Inconsistent indentation detected.

houndci-bot · 2018-02-18T20:05:34Z

2018/IvanKarpechanka/1/hw.rb

+gaps = (' ' * number_max_len)
+help_str = "\/#{gaps}\\#{gaps}" # Specifying a Tree Display Template
+(0..three_len).each do |i|
+	str = '' # to create an output line on the console of each line of the tree


Use 2 (not 1) spaces for indentation.
Tab detected.

houndci-bot · 2018-02-18T20:08:36Z

2018/IvanKarpechanka/1/hw.rb

+gaps = (' ' * number_max_len)
+help_str = "\/#{gaps}\\#{gaps}" # Specifying a Tree Display Template
+(0..three_len).each do |i|
+str = '' # to create an output line on the console of each line of the tree


Use 2 (not 0) spaces for indentation.

houndci-bot · 2018-02-18T20:35:06Z

2018/IvanKarpechanka/1/hw.rb

+  str += elem.to_s.rjust(number_max_len, '0') + (gaps + '  ')
+end
+help1 = ' ' * three_len.to_s.length
+puts help1 + (help_str * i).chomp(gaps).center(console_len)


Inconsistent indentation detected.

houndci-bot · 2018-02-18T20:35:06Z

2018/IvanKarpechanka/1/hw.rb

+pascals_row(i, first_el).each do |elem|
+  str += elem.to_s.rjust(number_max_len, '0') + (gaps + '  ')
+end
+help1 = ' ' * three_len.to_s.length


Inconsistent indentation detected.

houndci-bot · 2018-02-18T20:35:06Z

2018/IvanKarpechanka/1/hw.rb

+help_str = "\/#{gaps}\\#{gaps}"
+(0..three_len).each do |i|
+  str = ''
+pascals_row(i, first_el).each do |elem|


Inconsistent indentation detected.

Xanderwot · 2018-03-11T19:58:28Z

2018/IvanKarpechanka/1/hw.rb

+gaps = (' ' * number_max_len)
+help_str = "\/#{gaps}\\#{gaps}"
+(0..three_len).each do |i|
+  str = ''


2 пробела

Xanderwot · 2018-03-11T19:59:09Z

2018/IvanKarpechanka/1/hw.rb

+console_len = `tput cols`.to_i
+gaps = (' ' * number_max_len)
+help_str = "\/#{gaps}\\#{gaps}"
+(0..three_len).each do |i|


three_len.times do |tree_level|

Xanderwot · 2018-03-11T19:59:51Z

2018/IvanKarpechanka/1/hw.rb

@@ -0,0 +1,30 @@
+def fact(n)


Используй более дружелюбные переменные, чтобы можно было читать код легко, а не гадать что такое n, k или j

Xanderwot · 2018-03-11T20:06:16Z

2018/IvanKarpechanka/1/hw.rb

+  pascals_row(i, first_el).each do |elem|
+    str += elem.to_s.rjust(number_max_len, '0') + (gaps + '  ')
+  end
+  help1 = ' ' * three_len.to_s.length


help1 прям очень плохо. Я уверен ты можешь лучше.

Xanderwot · 2018-03-11T20:06:28Z

2018/IvanKarpechanka/1/hw.rb

+  end
+  help1 = ' ' * three_len.to_s.length
+  puts help1 + (help_str * i).chomp(gaps).center(console_len)
+  help2 = i.to_s.rjust(three_len.to_s.length, '0')


аналогично с help1

implement hw 1

0469d7f

houndci-bot reviewed Feb 18, 2018

View reviewed changes

implement hw 1 fixed

4f1c57b

houndci-bot reviewed Feb 18, 2018

View reviewed changes

implement hw 1 fixed1

5864c76

houndci-bot reviewed Feb 18, 2018

View reviewed changes

ivkarpechenko added 2 commits February 18, 2018 23:02

implement hw 1 fixed2

7be5a3e

implement hw 1 fixed2

0ebe9db

houndci-bot reviewed Feb 18, 2018

View reviewed changes

implement hw 1 fixed2

b609ff6

houndci-bot reviewed Feb 18, 2018

View reviewed changes

ivkarpechenko added 4 commits February 18, 2018 23:10

implement hw 1 fixed2

095b970

implement hw 1 fixed2

8ca1737

implement hw 1 fixed4

d06a288

implement hw 1 fixed4

000478f

houndci-bot reviewed Feb 18, 2018

View reviewed changes

ivkarpechenko added 2 commits February 18, 2018 23:36

implement hw 1 fixed4

77fe7de

implement hw 1 fixed4

452a5b4

Xanderwot suggested changes Mar 11, 2018

View reviewed changes

Xanderwot force-pushed the master branch from 09bb498 to 5568ad9 Compare March 27, 2018 14:45

Conversation

ivkarpechenko commented Feb 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Фамилия Имя

Email

Номер домашнего задания

Ссылка на видео с демо работы

Комментарии

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

ivkarpechenko commented Feb 18, 2018 •

edited

Loading