Open
Conversation
houndci-bot
reviewed
Apr 16, 2018
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Lint/BlockAlignment has the wrong namespace - should be Layout
.rubocop.yml: Lint/BlockAlignment has the wrong namespace - should be Layout .rubocop.yml: Lint/DefEndAlignment has the wrong namespace - should be Layout .rubocop.yml: Lint/EndAlignment has the wrong namespace - should be Layout Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml `Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead obsolete parameter MaxLineLength (for Style/WhileUntilModifier) found in .rubocop.yml `Style/WhileUntilModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Фамилия Имя
Добшиков Анатолий
Email
anatoly.dobshikov@mail.ru
Номер домашнего задания
2
Ссылка на видео с демо работы
https://youtu.be/Wpzg-VE5PXE
Комментарии
Бот работает с postgresql через active record; с api телеграма через telegram-bot-ruby; с api github через octokit и через curl. Что-то непонятное и страшное было с методом api git'a search/commits - он не хотел видеть paging от меня, а так мне все понравилось. Видео долгое получилось, но музыка скрасит время, проведенное за его просмотром.
Ссылка на бота: t.me/Cindy_GitHelper_Bot. Вдруг кто захочет поиграться, а у меня будет запущен клиент)
Валидация репозиториев присутствует, но по базе данных из видео можно подумать, что это не так. Это связано с тем, что я не дропнул таблицу после нескольких тестов, к которым я подключал всех желающих (т.е. заставлял силой всех, до кого дотянулся).