Skip to content

Comments

Remove weak/node-gyp dependency#71

Open
swim wants to merge 2 commits intoruipgil:masterfrom
swim:remove-weak-dep
Open

Remove weak/node-gyp dependency#71
swim wants to merge 2 commits intoruipgil:masterfrom
swim:remove-weak-dep

Conversation

@swim
Copy link

@swim swim commented Mar 23, 2017

When running Phantom on a Windows box it defaults to requiring node-gyp. However, this is not required; please see https://github.com/amir20/phantomjs-node/tree/v1#use-it-in-windows. This should also address an old issue #2.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.441% when pulling 093a911 on swim:remove-weak-dep into 4ae680b on ruipgil:master.

@ruipgil
Copy link
Owner

ruipgil commented Apr 2, 2017

You can pass an object with those functions, when you're instantiating a dynamic scraper. I feel that this is unnecessary to be baked in. Maybe a note in the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants