Exclude symbols when checking binding types#364
Open
SegaraRai wants to merge 1 commit intorunem:masterfrom
Open
Exclude symbols when checking binding types#364SegaraRai wants to merge 1 commit intorunem:masterfrom
SegaraRai wants to merge 1 commit intorunem:masterfrom
Conversation
|
Is there any update on merging this? It would be great to have this merged and published, and I'm surprised it hasn't been resolved already! Binding |
JackRobards
added a commit
to JackRobards/lit-analyzer
that referenced
this pull request
Jan 20, 2025
Taken from this PR/commit from the original repo. runem#364
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR excludes ES symbol types from unions when checking bindings.
This ensures that
nothingandnoChangeare ignored in type checking.We remove all symbol types because it is not possible to get the details of symbol types.
This will produce false negatives when other symbols are mixed in, but I consider such situations to be rare.
Closes #207. Closes #251. Closes #316.
This PR does not resolve the issue of
ifDefinednot supportingnull(even though Lit v3 does).It will probably be resolved when we stop treating
ifDefinedspecially, or when #296 is merged.The user can use either a custom directive or
value ?? nothinginstead ofifDefinedto workaround the issue.