Polymer analyzer: add event parsing when a property is defined with notify true#250
Open
jpradelle wants to merge 3 commits intorunem:masterfrom
Open
Polymer analyzer: add event parsing when a property is defined with notify true#250jpradelle wants to merge 3 commits intorunem:masterfrom
jpradelle wants to merge 3 commits intorunem:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analysis of Polymer custom components doesn't report Polymer events of properties with notify: true attribute.
This pull request adds it according to documentation: https://polymer-library.polymer-project.org/3.0/docs/devguide/data-system#change-events
Example of analyzed source
Markdown result with pull request code
polymer-test
Events
foo-bar-changedCustomEvent<{value: *, path: ?string}>fooBarproperty changestest-eventCustomEvent<{foo: string}>Markdown result without pull request code
Events
test-eventCustomEvent<{foo: string}>