Update @runtipi common to 1.0.1 to avoid tests breaking#8
Update @runtipi common to 1.0.1 to avoid tests breaking#8khaosdoctor wants to merge 2 commits intoruntipi:mainfrom
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughThe "@runtipi/common" dependency in package.json is updated from version ^0.8.0 to ^1.0.1. This is a dependency version bump with no other functional modifications to the codebase. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the @runtipi/common dependency from version 0.8.0 to 1.0.1 to fix a type definition issue in the dynamicComposeSchema. The old version incorrectly defined the environments property as Record<string, string | number> when it should be Array<Record<string, string | number>>.
Key Changes
- Updated
@runtipi/commondependency from^0.8.0to^1.0.1in package.json to fix the zod schema validation issue for dynamic compose JSON files
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The zod definition in 0.8.0 is accepting only a
Record<string, string | number>forenvironmentsin the dynamic compose JSON, when the correct is an array of objects (Array<Record<string, string | number>>) this is already implemented in the newest versionSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.