convert efitimeus_t to tagged_numeric_t #6409#15
Closed
kifir23917 wants to merge 2 commits intorusefi:masterfrom
Closed
convert efitimeus_t to tagged_numeric_t #6409#15kifir23917 wants to merge 2 commits intorusefi:masterfrom
kifir23917 wants to merge 2 commits intorusefi:masterfrom
Conversation
mck1117
reviewed
Apr 25, 2024
| * 64 bit time in microseconds (1/1_000_000 of a second), since boot | ||
| */ | ||
| using efitimeus_t = int64_t; | ||
| using efitimeus_t = tagged_numeric_t<timestamp_tag_s<int64_t, time_unit::MICROSECOND>>; |
Contributor
There was a problem hiding this comment.
can/should we just use std::chrono instead?
Member
Author
There was a problem hiding this comment.
Well, it makes sense. I will rewrite code using std::chrono::duration<int64_t, micros> and std::chrono::time_point.
Contributor
There was a problem hiding this comment.
Well, it makes sense. I will rewrite code using std::chrono::duration<int64_t, micros> and std::chrono::time_point.
What about our 1/168_000_000 second ticks and our 1/218_000_000 second tickets depending on target platform?
Contributor
There was a problem hiding this comment.
What about our 1/168_000_000 second ticks and our 1/218_000_000 second tickets depending on target platform?
// 4mhz was chosen because it's the GCD of (84, 108, 200), the three speeds of STM32 TIM5 clock currently supported
// https://www.wolframalpha.com/input/?i=common+factors+of+168+180+216
#define US_TO_NT_MULTIPLIER (4)
Contributor
There was a problem hiding this comment.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.