Conversation
rusefillc
reviewed
Mar 16, 2025
pt2001/src/pt2001.cpp
Outdated
| // debug | ||
| // why is this not a uint8_t?? | ||
| // or do we check the return is within range to prevent overflow | ||
| volatile uint16_t tmp; |
Contributor
There was a problem hiding this comment.
compiler is asking to comment out unused variable 'tmp'
initial microcode and memory locations for boost duration fixing some tmp vars
NOx-z
force-pushed
the
gdi4boostduration2
branch
from
507effd to
469283a
Compare
NOx-z
force-pushed
the
gdi4boostduration2
branch
from
8681388 to
f48790e
Compare
Contributor
NOx-z
force-pushed
the
gdi4boostduration2
branch
from
c223023 to
ce814d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initial microcode and memory locations for boost duration