libgit2-sys: More types and functions #1181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note: (Rust 1.88.0, Linux 6.16.0-arch2-1, libgit2 1:1.9.1-1) |
weihanglo
reviewed
Dec 22, 2025
Member
weihanglo
left a comment
weihanglo
left a comment
There was a problem hiding this comment.
It looks mostly good to me at the first glance. I need to take a second pass on it when I have time
Added type definition for struct `libgit2-sys::git_odb_stream`. Previously incorrectly defined as an opaque enum. See git2/odb_backend.h line 196. The `oid_type` field is conditionally included when the `unstable-sha256` feature is enabled (GIT_EXPERIMENTAL_SHA256). Added type definition for enum `git_odb_stream_t`. It corresponds to the `mode` field of `git_odb_stream`. See git2/odb_backend.h line 182.
Added struct `git_config_backend_entry`. See git2/sys/config.h line 27. Added struct `git_config_iterator`. Previously incorrectly defined as an empty enum. See git2/sys/config.h line 49. Added struct `git_config_backend`. See git2/sys/config.h line 69. Added constant `GIT_CONFIG_BACKEND_VERSION`. See git2/sys/config.h line 103. Added function `git_config_add_backend`. See git2/sys/config.h line 140. Added function `git_config_init_backend`. See git2/sys/config.h line 116.
Added struct `git_reference_iterator`. See git2/sys/refdb_backend.h line 35.
`git_commit_nth_gen_ancestor`'s first argument has been changed to `ancestor` from the previous `commit` to bring it closer to the actual definition (git2/commit.h line 282) and because the previous name is also used for the second argument.
The `unlock` function takes a second `c_int` argument for success status.
weihanglo
force-pushed
the
feat/more-sys-bindings
branch
from
60d0dc4 to
67c7902
Compare
weihanglo
approved these changes
Jan 12, 2026
Member
weihanglo
left a comment
weihanglo
left a comment
There was a problem hiding this comment.
Thanks for the PR! I've rebased onto master and made a few adjustments:
-
Removed non-public APIs:
git_config_backend_from_stringgit_config_backend_from_valuesgit_config_backend_memory_options
They use
externnotGIT_EXTERN()in libgit2, so not exported to the shared library. -
Added
oid_typetogit_odb_streambehind#[cfg(feature = "unstable-sha256")].
Also squashed some intermediate fix commits.
Thanks again. I am going to merge this when CI is green!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few more types and functions to libgit2-sys.
The changes should be largely correct but I might've missed a
c_intsomewhere or accidentally forgotten to make itc_uintinstead ofc_int.Full list of additions:
struct git_odb_stream(previously existed as an empty enum, exposed in git2/odb_backend.h line 196)enum git_odb_stream_t(exposed in git2/odb_backend.h line 182)struct git_config_backend_entry(exposed in git2/sys/config.h line 27)struct git_config_iterator(previously existed as an empty enum, exposed in git2/sys/config.h line 49)struct git_config_backend(exposed in git2/sys/config.h line 69)const GIT_CONFIG_BACKEND_VERSION(exposed in git2/sys/config.h line 103)struct git_config_backend_memory_options(exposed in git2/sys/config.h line 148)const GIT_CONFIG_BACKEND_MEMORY_OPTIONS_VERSION(exposed in git2/sys/config.h line 165)fn git_config_add_backend(exposed in git2/sys/config.h line 140)fn git_config_backend_from_string(exposed in git2/sys/config.h line 181)fn git_config_backend_from_values(exposed in git2/sys/config.h line 197)fn git_config_init_backend(exposed in git2/sys/config.h line 116)struct git_reference_iterator(previously existed as an empty enum, exposed in git2/sys/refdb_backend.h line 35)Additionally,
git_commit_nth_gen_ancestor's first argument was renamed toancestor(see b7ce5e6 for more comments).