[WIP] feat: unstable SHA256 support #1202
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not behind any experimental flag. Should be fine exposing directly
`git_oid_iszero` has been deprecated.
Raw git_oid binding has an extra field for object format kind. The old all-zeroed struct is now an valid oid when the feature `unstable-sha256` is enabled. This adds an warning to the `Oid::zero` function that it should only be used an output parameter when talking to C API. If you need valid zeroed input parameter, use libgit2 constants `GIT_OID_SHA*_ZERO` instead.
This adds an `unstable-sha256` Cargo feature, as a follow-up of rust-lang#1201 Also adds some smoke tests for affected operations/types. ## Insta-stable * **NEW** `ObjectFormat` enum with variants `Sha1` * **NEW** `Repository::object_format()` to query hash algorithm * **NEW** `Index::with_object_format` to create with different format ## Behind `unstable-sha256 * **NEW** `ObjectFormat` enum with variants `Sha1` and `Sha256` * **NEW** `RepositoryInitOptions::object_format()` method to set hash algo * **CHANGED** `Diff::from_buffer` to accept a extra object format argument * **CHANGED** `Index::open` to accept a extra object format argument * **CHANGED** `Indexer::new` to accept a extra object format argument * **CHANGED** `Oid::from_str` to accept a extra object format argument * **CHANGED** `Oid::hash_{object,file}` to accept a extra object format argument * **REMOVED** `Index::new` to avoid misuse. * **REMOVED** `impl std::FromStr for Oid` to avoid misuse
This was referenced Jan 3, 2026
Open
This was referenced Jan 11, 2026
weihanglo
changed the title
Collaborator
|
☔ The latest upstream changes (possibly 991c346) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
Author
|
Accidentally deleted the branch. Anyway, this is still waiting for a new release of libgit2 with some of my patches. Will post a new one when time comes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on libgit2/libgit2#7182
This adds an
unstable-sha256Cargo feature,as a follow-up of #1201
Also adds some smoke tests for affected operations/types.
Part of #1090
Insta-stable
ObjectFormatenum with variantsSha1Repository::object_format()to query hash algorithmIndex::with_object_formatto create with different formatBehind
unstable-sha256ObjectFormatenum with variantsSha1andSha256RepositoryInitOptions::object_format()method to set hash algoDiff::from_bufferto accept a extra object format argumentIndex::opento accept a extra object format argumentIndexer::newto accept a extra object format argumentOid::from_strto accept a extra object format argumentOid::hash_{object,file}to accept a extra object format argumentIndex::newto avoid misuse.impl std::FromStr for Oidto avoid misuse