feat: Add destructure_enum assist #21457
Open
+189
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r-a already has the ability to fill in match arms as part of the add_missing_match_arms assist. However, there's currently no way to go from
flavortomatch flavor { Apple => {} ... }.If a user does want the IDE to fill in match arms, they have to write the
matchand{}themselves. Other language LSPs supporting pattern matching (e.g. merlin for OCaml) support writing the whole match statement.Whilst I'm aware there's a freeze on new assists, this assist is just a generalisation of add_missing_match_arms and reuses the existing logic there (which has great test coverage). I think it's a really compelling feature and hopefully a small ask.
AI disclosure: Written with a little bit of help from Claude in a few places.