Skip to content

Remove suggestion from importing unstable items on stable channel #149440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
chenyukang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove suggestion from importing unstable items on stable channel #149440

chenyukang wants to merge 1 commit into from

Conversation

@chenyukang
Copy link
Member

@chenyukang chenyukang commented Nov 29, 2025 •
edited by rustbot
Loading

Fixes #149402

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 29, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 29, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

fee1-dead
fee1-dead requested changes Nov 30, 2025
View reviewed changes
Copy link
Member

@fee1-dead fee1-dead left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after addressing nit

View changes since this review

tests/ui/resolve/suggest-unresolve-nightly-149402.rs Outdated
@@ -0,0 +1,9 @@
//@ only-nightly
Copy link
Member

@fee1-dead fee1-dead Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to use revisions here to avoid duplicating the same file?

Copy link
Member Author

@chenyukang chenyukang Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, fixed in https://github.com/rust-lang/rust/compare/5b003456246ad18d3141eb748d750f152f51194f..34c80e46389304d906fcb50efe4cf32a0270fab7

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2025
@chenyukang
Copy link
Member Author

chenyukang commented Nov 30, 2025

@bors r=fee1-dead

@bors
Copy link
Collaborator

bors commented Nov 30, 2025

📌 Commit 34c80e4 has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 30, 2025
bors added a commit that referenced this pull request Nov 30, 2025
@bors
Auto merge of #149440 - chenyukang:yukang/issue-149402, r=fee1-dead
2699798 
Remove suggestion from importing unstable items on stable channel

Fixes #149402
@bors
Copy link
Collaborator

bors commented Nov 30, 2025

⌛ Testing commit 34c80e4 with merge 2699798...

bors added a commit that referenced this pull request Nov 30, 2025
@bors
Auto merge of #149440 - chenyukang:yukang/issue-149402, r=fee1-dead
8787ed6 
Remove suggestion from importing unstable items on stable channel

Fixes #149402
@bors
Copy link
Collaborator

bors commented Nov 30, 2025

⌛ Testing commit 34c80e4 with merge 8787ed6...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Nov 30, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 30, 2025
@chenyukang
Copy link
Member Author

chenyukang commented Nov 30, 2025

@jieyouxu
do you know how to add test case only for stable channel?

I build a stage2 on local machine, and found out the is_nightly_build() returns true, I think it's the same in CI testing.

https://github.com/chenyukang/rust/blob/34c80e46389304d906fcb50efe4cf32a0270fab7/compiler/rustc_resolve/src/diagnostics.rs#L1612

From the code, seems we will set CFG_DISABLE_UNSTABLE_FEATURES for stable channel.
https://github.com/chenyukang/rust/blob/34c80e46389304d906fcb50efe4cf32a0270fab7/compiler/rustc_feature/src/lib.rs#L84

@jieyouxu jieyouxu self-assigned this Dec 1, 2025
@jieyouxu

This comment was marked as outdated.

Sign in to view
@jieyouxu
Copy link
Member

jieyouxu commented Dec 1, 2025 •
edited
Loading

Ok, it looks like RUSTC_BOOTSTRAP overriding CFG_DISABLE_UNSTABLE_FEATURES is intentional (at least, that's what the original logic was also doing), as otherwise, you can't even bootstrap.

One option you may have is to write this as a run-make test, with two stderr tracked: a stable rustc, and an unstable rustc. Gate the run-make itself using //@ only-nightly, but have the nightly rustc "pretend" to be a stable rustc with RUSTC_BOOTSTRAP=-1. Have a look at

rust/tests/run-make/print-request-help-stable-unstable/rmake.rs

Line 8 in dfe1b8c

.env("RUSTC_BOOTSTRAP", "-1")
for an example. That should still allow you to compare the diffs generated by the same rustc as if it reached stable.

@jieyouxu jieyouxu removed their assignment Dec 1, 2025
@fee1-dead
Copy link
Member

fee1-dead commented Dec 5, 2025

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 5, 2025
@jhpratt
Copy link
Member

jhpratt commented Jan 4, 2026

@bors r- (sync)

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 11, 2026

☀️ Try build successful (CI)
Build commit: 2becfd8 (2becfd84b3e4b0497d53de71a96a7445eeb41218, parent: ad04f76d844d2624fa80e1186abd1497196597a1)

@chenyukang chenyukang force-pushed the yukang/issue-149402 branch 2 times, most recently from 759c504 to e1aee29 Compare January 11, 2026 08:09
@chenyukang
Copy link
Member Author

chenyukang commented Jan 11, 2026

@bors try jobs=x86_64-gnu-stable

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Jan 11, 2026
@rust-bors
Auto merge of #149440 - chenyukang:yukang/issue-149402, r=<try>
8040691 
Remove suggestion from importing unstable items on stable channel

try-job: x86_64-gnu-stable
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 11, 2026

☀️ Try build successful (CI)
Build commit: 8040691 (80406917fa6db1862ade08d7db8a655c5c41063a, parent: 9bc8b40bc314b74e1d5e5ab21a0df39c55a34806)

@chenyukang
Copy link
Member Author

chenyukang commented Jan 12, 2026

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 12, 2026
@fee1-dead
Copy link
Member

fee1-dead commented Jan 18, 2026

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 18, 2026

📌 Commit e1aee29 has been approved by fee1-dead

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 18, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Jan 18, 2026
@jhpratt
Rollup merge of rust-lang#149440 - yukang/issue-149402, r=fee1-dead
b9dd401 
Remove suggestion from importing unstable items on stable channel

Fixes rust-lang#149402
@jhpratt jhpratt mentioned this pull request Jan 18, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Jan 18, 2026
@bors
Auto merge of #151285 - jhpratt:rollup-cxrAf4M, r=jhpratt
23ae437 
Rollup of 9 pull requests

Successful merges:

 - #148769 (Stabilize `alloc_layout_extra`)
 - #149440 (Remove suggestion from importing unstable items on stable channel)
 - #150200 (Add title field to `ice.md` issue template)
 - #150955 (Underscore-prefixed bindings are explicitly allowed to be unused)
 - #151200 (time: Add saturating arithmetic for `SystemTime`)
 - #151235 (Change field `bit_width: usize` to `bits: u32` in type info)
 - #151242 (Port #[needs_allocator] to attribute parser)
 - #151274 (Include a link to `count_ones` in the docs for `uN::count_zeros` [docs only])
 - #151279 (remove trailing periods in built-in attribute gate messages)

r? @ghost
@jhpratt
Copy link
Member

jhpratt commented Jan 18, 2026

@bors r-

#151285 (comment)

@rust-bors rust-bors bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 18, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 18, 2026

Commit e1aee29 has been unapproved.

@rust-bors rust-bors bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 18, 2026
@chenyukang
Copy link
Member Author

chenyukang commented Jan 18, 2026

@bors try jobs=dist-various-1

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Jan 18, 2026
@bors
Auto merge of #149440 - chenyukang:yukang/issue-149402, r=<try>
e8af78d 
Remove suggestion from importing unstable items on stable channel


try-job: dist-various-1
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 18, 2026

☀️ Try build successful (CI)
Build commit: e8af78d (e8af78d927e50dba8c849a2b95b5a5e142f826b8, parent: 621d76794c76fc21c0a6151fbc090120e0230a91)

@chenyukang
Copy link
Member Author

chenyukang commented Jan 19, 2026

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fee1-dead fee1-dead fee1-dead requested changes

Assignees

@fee1-dead fee1-dead

Labels

A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Don't suggest stuff (that doesn't really exist) from nightly when on stable

7 participants

@chenyukang @rustbot @bors @rust-log-analyzer @jieyouxu @fee1-dead @jhpratt