Skip to content

Conversation

@Zalathar
Copy link
Member

@Zalathar Zalathar commented Jan 5, 2026

This is a bit more verbose, but clearly indicates which variant fields are being ignored, which is helpful for this sort of exhaustive lowering step.

Inspired by #150681 (comment).

There should be no change to compiler behaviour.

@rustbot
Copy link
Collaborator

rustbot commented Jan 5, 2026

Some changes occurred in match lowering

cc @Nadrieril

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 5, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 5, 2026

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Nadrieril
Copy link
Member

Nadrieril commented Jan 5, 2026

I dunno, I find this kind of thing adds more friction than help... If I add a field to an enum like this it's always only going to get used at one or two use sites. thir::PatKind is used in quite a few places too. I'm the kind of person who actively does the exact opposite change than this PR i.e. adding , .. to save us from future pain.

@Zalathar
Copy link
Member Author

Zalathar commented Jan 5, 2026

Hmm, you might be right.

This is not a big deal either way, so I'm happy to close.

@Nadrieril
Copy link
Member

My preference would be to leave things as-is yea

@Zalathar Zalathar closed this Jan 5, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 5, 2026
@Zalathar Zalathar deleted the exhaustive branch January 5, 2026 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants