Skip to content

Rollup of 3 pull requests #150692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 6 commits into from
Jan 5, 2026
Merged

Rollup of 3 pull requests #150692

bors merged 6 commits into from
Jan 5, 2026

Conversation

@jhpratt
Copy link
Member

@jhpratt jhpratt commented Jan 5, 2026 •
edited by rustbot
Loading

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

matwatson and others added 6 commits October 15, 2025 22:41
@matwatson
corrected Cell<T> module level doc
d056f59 
replaced `&mut T` with `&T` to finally state
"a &T to the inner value can never be obtained"
@Ayush1325
std: sys: fs: uefi: Implement rename
b725981 
- Using the file_name field in `EFI_FILE_INFO` works for renaming, even
  when changing directories.
- Does not work for cross-device rename, but that is already expected
  behaviour according to the docs:

  "This will not work if the new name is on a different mount point."

- Also add some helper code for dealing with UefiBox<file::Info>.
- Tested using OVMF in qemu.

Signed-off-by: Ayush Singh <ayush@beagleboard.org>
@lasiotus
Motor OS: fix compile error
3f1dd92 
PR rust-lang#146341 introduced
a compilation error. This fixes it.
@jhpratt
Rollup merge of rust-lang#146863 - matwatson:core-cell-improve-doc, r…
fe5a1d7 
…=tgross35

Update cell.rs, correct module level doc

This change corrects the Cell<T> section by replacing `&mut` with `&` so the statement reads "an &T to the inner value can never be obtained". It also emphasizes that a single &mut T to the inner value can be obtained (e.g. via method core::cell::Cell::get_mut).
@jhpratt
Rollup merge of rust-lang#150547 - Ayush1325:uefi-rename, r=jhpratt
a1221de 
std: sys: fs: uefi: Implement rename

- Using the file_name field in `EFI_FILE_INFO` works for renaming, even when changing directories.
- Does not work for cross-device rename, but that is already expected behaviour according to the docs:

  "This will not work if the new name is on a different mount point."

- Also add some helper code for dealing with UefiBox<file::Info>.
- Tested using OVMF in qemu.
- edk2 implementation of the same: https://github.com/tianocore/edk2/blob/66346d5edeac2a00d3cf2f2f3b5f66d423c07b3e/ShellPkg/Library/UefiShellLevel2CommandsLib/Mv.c#L455

``@rustbot`` label +O-UEFI
@jhpratt
Rollup merge of rust-lang#150684 - moturus:main, r=jhpratt
d788ec5 
Motor OS: fix compile error

PR rust-lang#146341 introduced a compilation error. This fixes it.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 5, 2026
@jhpratt
Copy link
Member Author

jhpratt commented Jan 5, 2026

@bors r+ rollup=never p=3

@bors
Copy link
Collaborator

bors commented Jan 5, 2026

📌 Commit d788ec5 has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 5, 2026
@bors
Copy link
Collaborator

bors commented Jan 5, 2026

⌛ Testing commit d788ec5 with merge 9e8a0c5...

@bors
Copy link
Collaborator

bors commented Jan 5, 2026

☀️ Test successful - checks-actions
Approved by: jhpratt
Pushing 9e8a0c5 to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 5, 2026
@bors bors merged commit 9e8a0c5 into rust-lang:main Jan 5, 2026
12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 5, 2026
@rust-timer
Copy link
Collaborator

rust-timer commented Jan 5, 2026

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#146863 Update cell.rs, correct module level doc d975defcaf90234843c13d70677f0830b742fc37 (link)
#150547 std: sys: fs: uefi: Implement rename 1165fa669a2bf0ed350fd560a03bba75455fda26 (link)
#150684 Motor OS: fix compile error a19b48afb75ebaf0ebea209908f3cafeb706bc4a (link)

previous master: 0d162b25ed

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 0d162b2 (parent) -> 9e8a0c5 (this PR)

Test differences

Show 240 test diffs

240 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 9e8a0c51641114b46b2dba657a121b2483b5aee3 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-apple-various: 3926.8s -> 4738.0s (+20.7%)
  2. dist-x86_64-apple: 7964.3s -> 9550.0s (+19.9%)
  3. tidy: 152.1s -> 176.0s (+15.7%)
  4. x86_64-gnu-gcc: 3887.6s -> 3370.9s (-13.3%)
  5. aarch64-msvc-1: 6831.1s -> 7731.8s (+13.2%)
  6. x86_64-gnu-llvm-20: 5348.3s -> 4689.3s (-12.3%)
  7. x86_64-gnu-llvm-21-3: 6234.9s -> 6962.9s (+11.7%)
  8. aarch64-apple: 8759.0s -> 9527.3s (+8.8%)
  9. dist-various-2: 2166.4s -> 2351.5s (+8.5%)
  10. dist-x86_64-netbsd: 5279.1s -> 4832.3s (-8.5%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

rust-timer commented Jan 5, 2026

Finished benchmarking commit (9e8a0c5): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.5% [1.5%, 1.5%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.5% [-0.6%, -0.2%] 4
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.2% [-2.3%, -2.1%] 2
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.2% [-2.3%, -2.1%] 2

Cycles

Results (primary 2.1%, secondary 3.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 2.1% [2.1%, 2.1%] 1
Regressions ❌
(secondary)		 3.4% [3.4%, 3.4%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 2.1% [2.1%, 2.1%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.733s -> 474.474s (-0.05%)
Artifact size: 390.86 MiB -> 390.78 MiB (-0.02%)

@jhpratt jhpratt deleted the rollup-kfi61p5 branch January 5, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

7 participants

@jhpratt @bors @rust-timer @rustbot @matwatson @Ayush1325 @lasiotus