Skip to content

Use default field values in a few more cases #151172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
estebank wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use default field values in a few more cases #151172

estebank wants to merge 1 commit into from
+22 −46

Conversation

@estebank
Copy link
Contributor

@estebank estebank commented Jan 15, 2026

Makes the use expressions significantly shorter.

@estebank
Use default field values in a few more cases
b4781c8 
Makes the use expressions significantly shorter.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 15, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 15, 2026

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

dianne
dianne approved these changes Jan 16, 2026
View reviewed changes
Copy link
Contributor

@dianne dianne left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r? me
@bors r+ rollup

View changes since this review

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 16, 2026

📌 Commit b4781c8 has been approved by dianne

It is now in the queue for this repository.

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 16, 2026
@rust-bors rust-bors bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 16, 2026
@Zalathar
Copy link
Member

Zalathar commented Jan 16, 2026

What’s the status of feature(default_field_values) in rust-analyzer these days?

If we end up with more source files that can’t be opened without triggering unavoidable bogus IDE errors, that seems worse than any benefit gained from the shorter syntax.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 16, 2026
@matthiaskrgr
Rollup merge of rust-lang#151172 - default-field-values, r=dianne
d2d634b 
Use default field values in a few more cases

Makes the use expressions significantly shorter.
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 16, 2026
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 16, 2026
@matthiaskrgr
Rollup merge of rust-lang#151172 - default-field-values, r=dianne
f938792 
Use default field values in a few more cases

Makes the use expressions significantly shorter.
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 16, 2026
Closed
@dianne
Copy link
Contributor

dianne commented Jan 16, 2026

What’s the status of feature(default_field_values) in rust-analyzer these days?

Oh, huh, it looks like it produces "missing struct field" errors on use. I thought I'd used it successfully in the past, but I guess I must have misremembered.

@dianne
Copy link
Contributor

dianne commented Jan 16, 2026

Given that, if it's not too late, @bors r-
I think default field values adds a nice amount of clarity here, but I don't think it's worth the r-a errors. Sorry for the hasty decision.

@rust-bors rust-bors bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 16, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 16, 2026

Commit b4781c8 has been unapproved.

@rust-bors rust-bors bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 16, 2026
rust-bors bot pushed a commit that referenced this pull request Jan 16, 2026
@bors
Auto merge of #151192 - matthiaskrgr:rollup-uThdZGN, r=matthiaskrgr
336efc6 
Rollup of 4 pull requests

Successful merges:

 - #151155 (THIR patterns: Always use type `str` for string-constant-value nodes)
 - #151166 (fix: Do not delay E0107 when there exists an assoc ty with the same name)
 - #151172 (Use default field values in a few more cases)
 - #151185 (Disable `dump-ice-to-disk` on `i686-pc-windows-msvc`)

r? @ghost
@ShoyuVanilla
Copy link
Member

ShoyuVanilla commented Jan 16, 2026 •
edited
Loading

What’s the status of feature(default_field_values) in rust-analyzer these days?

If we end up with more source files that can’t be opened without triggering unavoidable bogus IDE errors, that seems worse than any benefit gained from the shorter syntax.

To elaborate on the current status of rust-analyzer,

@dianne
Copy link
Contributor

dianne commented Jan 16, 2026

Nice! I'll happily re-approve this once the feature's supported. In the mean time, maybe let's say this is blocked so it's not labeled as waiting on author or review? @rustbot blocked

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dianne dianne dianne approved these changes

Assignees

@dianne dianne

Labels

S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@estebank @rustbot @Zalathar @dianne @ShoyuVanilla @chenyukang