Disable dump-ice-to-disk on i686-pc-windows-msvc
#151185
Merged
+7
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes the middle frames of the ICE backtrace becomes `<unknown>` on `i686-pc-windows-msvc` which then makes this test flaky.
rustbot
added
A-run-make
Member
|
Thanks! |
Contributor
rust-bors
bot
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 16, 2026
Disable `dump-ice-to-disk` on `i686-pc-windows-msvc` Sometimes the middle frames of the ICE backtrace becomes `<unknown>` on `i686-pc-windows-msvc` which then makes this test flaky. Noticed in rust-lang#150925 (comment). Originally expanded in rust-lang#142563 to see if it's still flaky for other `*-windows-*` targets, unfortunately the answer is yes for `i686-pc-windows-msvc` as well. r? @dianqk (or compiler or anyone really)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 16, 2026
Disable `dump-ice-to-disk` on `i686-pc-windows-msvc` Sometimes the middle frames of the ICE backtrace becomes `<unknown>` on `i686-pc-windows-msvc` which then makes this test flaky. Noticed in rust-lang#150925 (comment). Originally expanded in rust-lang#142563 to see if it's still flaky for other `*-windows-*` targets, unfortunately the answer is yes for `i686-pc-windows-msvc` as well. r? @dianqk (or compiler or anyone really)
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 16, 2026
Rollup of 4 pull requests Successful merges: - #151155 (THIR patterns: Always use type `str` for string-constant-value nodes) - #151166 (fix: Do not delay E0107 when there exists an assoc ty with the same name) - #151172 (Use default field values in a few more cases) - #151185 (Disable `dump-ice-to-disk` on `i686-pc-windows-msvc`) r? @ghost
rust-timer
added a commit
that referenced
this pull request
Jan 16, 2026
Rollup merge of #151185 - disable-dump-ice-i686, r=dianqk Disable `dump-ice-to-disk` on `i686-pc-windows-msvc` Sometimes the middle frames of the ICE backtrace becomes `<unknown>` on `i686-pc-windows-msvc` which then makes this test flaky. Noticed in #150925 (comment). Originally expanded in #142563 to see if it's still flaky for other `*-windows-*` targets, unfortunately the answer is yes for `i686-pc-windows-msvc` as well. r? @dianqk (or compiler or anyone really)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the middle frames of the ICE backtrace becomes
<unknown>oni686-pc-windows-msvcwhich then makes this test flaky. Noticed in #150925 (comment).Originally expanded in #142563 to see if it's still flaky for other
*-windows-*targets, unfortunately the answer is yes fori686-pc-windows-msvcas well.r? @dianqk (or compiler or anyone really)