Skip to content

Port #[needs_allocator] to attribute parser #151242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 1 commit into from
Jan 18, 2026
Merged

Port #[needs_allocator] to attribute parser #151242

rust-bors merged 1 commit into from
Jan 18, 2026
+17 −3

Conversation

@Ozzy1423
Copy link
Contributor

@Ozzy1423 Ozzy1423 commented Jan 17, 2026

Tracking issue: #131229

Ports needs_allocator attribute to the new attribute parser.
Note: this is a deprecated and feature gated attribute.

@rustbot
Copy link
Collaborator

rustbot commented Jan 17, 2026

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 17, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 17, 2026

r? @mati865

rustbot has assigned @mati865.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 17, 2026
Open
9 tasks
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Jan 17, 2026

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 17, 2026

📌 Commit ebfd227 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 17, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Jan 18, 2026
@jhpratt
Rollup merge of rust-lang#151242 - master, r=JonathanBrouwer
559235e 
Port #[needs_allocator] to attribute parser

Tracking issue: rust-lang#131229

Ports needs_allocator attribute to the new attribute parser.
Note: this is a deprecated and feature gated attribute.
@jhpratt jhpratt mentioned this pull request Jan 18, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Jan 18, 2026
@bors
Auto merge of #151285 - jhpratt:rollup-cxrAf4M, r=jhpratt
23ae437 
Rollup of 9 pull requests

Successful merges:

 - #148769 (Stabilize `alloc_layout_extra`)
 - #149440 (Remove suggestion from importing unstable items on stable channel)
 - #150200 (Add title field to `ice.md` issue template)
 - #150955 (Underscore-prefixed bindings are explicitly allowed to be unused)
 - #151200 (time: Add saturating arithmetic for `SystemTime`)
 - #151235 (Change field `bit_width: usize` to `bits: u32` in type info)
 - #151242 (Port #[needs_allocator] to attribute parser)
 - #151274 (Include a link to `count_ones` in the docs for `uN::count_zeros` [docs only])
 - #151279 (remove trailing periods in built-in attribute gate messages)

r? @ghost
@jhpratt jhpratt mentioned this pull request Jan 18, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Jan 18, 2026
@bors
Auto merge of #151291 - jhpratt:rollup-CVsL9ZN, r=jhpratt
ba2a7d3 
Rollup of 8 pull requests

Successful merges:

 - #148769 (Stabilize `alloc_layout_extra`)
 - #150200 (Add title field to `ice.md` issue template)
 - #150955 (Underscore-prefixed bindings are explicitly allowed to be unused)
 - #151200 (time: Add saturating arithmetic for `SystemTime`)
 - #151235 (Change field `bit_width: usize` to `bits: u32` in type info)
 - #151242 (Port #[needs_allocator] to attribute parser)
 - #151274 (Include a link to `count_ones` in the docs for `uN::count_zeros` [docs only])
 - #151279 (remove trailing periods in built-in attribute gate messages)

r? @ghost
@rust-bors rust-bors bot merged commit 845316c into rust-lang:main Jan 18, 2026
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 18, 2026
rust-timer added a commit that referenced this pull request Jan 18, 2026
@rust-timer
Unrolled build for #151242
c8dd1fd 
Rollup merge of #151242 - master, r=JonathanBrouwer

Port #[needs_allocator] to attribute parser

Tracking issue: #131229

Ports needs_allocator attribute to the new attribute parser.
Note: this is a deprecated and feature gated attribute.
@panstromek
Copy link
Contributor

panstromek commented Jan 19, 2026

Investigating regression from #151291. This doesn't look that perf sensitive to me, but we had seen regressions on other attribute ports, and there's not many other good candidates in that rollup.

@rust-timer build c8dd1fd

@rust-timer

This comment has been minimized.

Sign in to view
@cuviper cuviper modified the milestones: 1.94.0, 1.95.0 Jan 19, 2026
@rust-timer
Copy link
Collaborator

rust-timer commented Jan 19, 2026

Finished benchmarking commit (c8dd1fd): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -0.5%, secondary 3.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 0.9% [0.9%, 0.9%] 1
Regressions ❌
(secondary)		 3.1% [3.1%, 3.1%] 1
Improvements ✅
(primary)		 -1.8% [-1.8%, -1.8%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.5% [-1.8%, 0.9%] 2

Cycles

Results (secondary -2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.0% [-2.1%, -1.9%] 2
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.856s -> 473.69s (-0.25%)
Artifact size: 383.43 MiB -> 383.50 MiB (0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@JonathanBrouwer JonathanBrouwer

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

7 participants

@Ozzy1423 @rustbot @JonathanBrouwer @panstromek @rust-timer @cuviper @mati865