On nightly, impl const Default
#63
Open
+33
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estebank
force-pushed
the
const-Default
branch
from
0ad9256 to
6d9b6e9
Compare
Member
|
@oli-obk @fee1-dead @fmease are you fine with this? |
Author
Member
|
I think it is fine, yeah - just document why using a macro is necessary |
When the "nightly" feature is enabled, implement `const Default` for `FxHasher` and `FxBuildHasher`. This allows for types like `FxHashMap` to be used through `Default::default()` on `const` contexts.
estebank
force-pushed
the
const-Default
branch
from
6d9b6e9 to
2170d5e
Compare
Author
|
Added comment. It is because |
Noratrieb
approved these changes
Jan 16, 2026
Member
Noratrieb
left a comment
Noratrieb
left a comment
There was a problem hiding this comment.
sounds good to me then, I just wanted to make sure this doesn't create a significant burden for future const trait refactors.
Member
|
it would be nice if you could set up release-plz for the releases, like many other rust-lang repos :3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the "nightly" feature is enabled, implement
const DefaultforFxHasherandFxBuildHasher. This allows for types likeFxHashMapto be used throughDefault::default()onconstcontexts. Specifically, this will make it easier to dogfoodfeature(default_field_values)more extensively in the compiler, by being able to usefield: FxHashSet<DefId> = Default::default()instead offield: FxHashSet<DefId> = FxHashSet::with_hasher(FxBuildHasher).