fix(cli/rustup-mode): check for self updates for SelfUpdateMode::CheckOnly
#4680
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rami3l
force-pushed
the
fix/rustup-check-self-update-check-only
branch
from
ec75795 to
57ee792
Compare
rami3l
changed the title
rustup check for SelfUpdateMode::CheckOnlycheck for self updates for SelfUpdateMode::CheckOnly
ChrisDenton
approved these changes
Jan 15, 2026
Member
ChrisDenton
left a comment
ChrisDenton
left a comment
There was a problem hiding this comment.
That does make sense to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following concern of @steffahn:
It is quite likely that this section was originally copied over from
rustup updatewithout careful verification/review. My apologies.