Remove the mixed singular/plural phrasing as “component(s)”
#4682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Sounds good to me. |
rami3l
approved these changes
Jan 16, 2026
Member
rami3l
left a comment
rami3l
left a comment
There was a problem hiding this comment.
Many thanks!
Maybe let's just go with your later proposal instead? We'll have to update the snapshots anyway so...
Member
|
@steffahn Thanks for the update! Just squashing your changes into one commit and if the CI is all green we are good to go :) |
instead, use "components" or "component". In the singular case also add the name of the component for more consistent messaging style with other info! outputs about single components. Added during review: The plural case now also displays the number of components; and the snapshot tests are being updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, we can use "components" or "component" depending on the number (which is always known).
In the latter case also add the name of the component for more consistent messaging style with other
info!outputs about single components.Screenshot comparing the output for 2 scenarios in action (top half is before this PR):
Also I feel like it could be a reasonable idea [which this PR currently does not do (yet?)] to also add the number of components in the middle, i.e.
downloading componentswould further becomedownloading 6 componentsthen.I do expect some CI failure as
component(s)appears in some ui test – but I haven’t yet figured out how to run tests locally correctly, and it’s getting too late today.