Remove all uses of getrandom_backend = "wasm_js"
#771
Conversation
dhardy
left a comment
dhardy
left a comment
There was a problem hiding this comment.
Removal of getrandom_backend="wasm_js" is a breaking change; it makes sense to merge this before 0.4 (I assume this is your intention).
| - { | ||
| description: Web, | ||
| version: stable, | ||
| flags: '-Dwarnings --cfg getrandom_backend="wasm_js"', |
There was a problem hiding this comment.
We still want -Dwarnings (unless substituted below)
| # i.e. avoid unconditionally enabling it in library crates. | ||
| # | ||
| # WARNING: This feature SHOULD be enabled ONLY for binary crates and tests. In other words, | ||
| # avoid enabling it in library crates whether unconditionally or gated on a crate feature. |
There was a problem hiding this comment.
or gated on a crate feature
I see no hard reason not to have a "forwarding" feature flag (e.g. wasm_js = ["getrandom/wasm_js"]).
I know you don't like this pattern, but I don't think directing users like this will work particularly well.
I suggest we keep our advice direct and minimally opinionated:
We recommend against enabling this feature in libraries (except for tests) since it is known to break some non-Web WASM builds and further since the usage of
wasm-bindgencauses significant bloat toCargo.lock(on all targets).
Enabling the
wasm_jscrate feature is sufficient.