loader: Verify alignment of the LOAD segment for the x86-64 kernel #227
+42
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bysui
requested review from
ShadowCurse,
andreitraistaru,
rbradford,
roypat and
sameo
as code owners
For the x86-64 kernel, the loaded address must be aligned to 2MB; otherwise, the check in __startup_64() in the Linux kernel would fail and cause the kernel to hang. Therefore, verify the alignment of the LOAD segment during the loading process. Signed-off-by: Hou Wenlong <houwenlong.hwl@antgroup.com>
bysui
force-pushed
the
houwenlong/align
branch
from
bd94549 to
fd01289
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
For the x86-64 kernel, the loaded address must be aligned to 2MB; otherwise, the check in __startup_64() in the Linux kernel would fail and cause the kernel to hang. Therefore, verify the alignment of the LOAD segment during the loading process.
Actually, there is a check for the alignment of each LOAD segment [c55b8550fa57] in the Linux kernel decompression process; however, I didn't see such a check in QEMU PVH booting code, so I only checked the last loaded address.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.