Merge RawWindowHandle and WindowHandle<'w>#204
Draft
madsmtm wants to merge 3 commits intoprivate-fieldsfrom
Draft
Merge RawWindowHandle and WindowHandle<'w>#204madsmtm wants to merge 3 commits intoprivate-fieldsfrom
madsmtm wants to merge 3 commits intoprivate-fieldsfrom
Conversation
This allows structs to define additional safety invariants (which would otherwise be trivial to override by modifying the field). This allows done one of: - Adding reference-counting to platform handles. - Combining `WindowHandle<'_>` and `RawWindowHandle`. Depending on what we want to do in the future.
madsmtm
force-pushed
the
madsmtm/merge-raw
branch
from
80086db to
71b1da9
Compare
Makes using these easier, and allows writing more specific safety comments on each variant.
madsmtm
force-pushed
the
madsmtm/merge-raw
branch
from
71b1da9 to
6708809
Compare
madsmtm
force-pushed
the
private-fields
branch
3 times, most recently
from
bb7ffaf to
4316670
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes using these easier, and allows writing more specific safety comments on each variant.
Fixes #178.