Open
Conversation
notgull
requested changes
Mar 10, 2026
Comment on lines
-6
to
-19
| /// | ||
| /// ## Thread-Safety | ||
| /// | ||
| /// WASM objects are usually bound to the main UI "thread" belonging to the | ||
| /// top-level webpage. Therefore this type is `!Send` and `!Sync`. It cannot be | ||
| /// sent to or used from other threads. | ||
| /// | ||
| /// Note that this type does not contain any WASM objects. However, | ||
| /// it is kept `!Send` and `!Sync` for the event that WASM objects are | ||
| /// added to this type. | ||
| /// | ||
| /// However, this status quo may change in the future, due to the adoption of | ||
| /// atomics in WASM code. Therefore this type may be made `Send` and `Sync` as | ||
| /// part of a non-breaking change. |
Member
Author
There was a problem hiding this comment.
Same reason as #209 (comment): it doesn't make any sense on an empty type.
We might want to consider making it Send + Sync right now. I can't think of a reason not to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix some leftovers from #192.