Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently create a new
Veceach timenext_bufferis called on macOS/iOS, which is inefficient, we should instead re-use previous buffers.Double-buffering seems to be enough here, but in degenerate cases such as the following:
The buffer is still referenced by QuartzCore somewhere, so we need to keep a (potentially infinite) queue of buffers around to be sure that we don't write to a buffer that's in use. Note that there is no way to wait for the buffers to be released since the release happens on the main thread (and besides, we probably don't want to wait either?).
All of this might be overly pedantic, I haven't yet found a case where the buffer is actually read from by QuartzCore while being the back buffer (unlike with
IOSurface).Tested on:
Should help with #83.
Extracted from #329 (since that one may be more difficult to land).