Properly implement Debug for Window and EventLoop types#3297
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
madsmtm
force-pushed
the
better-debug
branch
2 times, most recently
from
384bc96 to
5a79634
Compare
madsmtm
requested review from
MarijnS95,
daxpedda,
jackpot51,
kchibisov and
notgull
as code owners
madsmtm
force-pushed
the
better-debug
branch
from
5a79634 to
e35500d
Compare
madsmtm
changed the title
Window and WindowBuilderWindow and EventLoop types
notgull
approved these changes
Mar 2, 2025
For EventLoop, EventLoopBuilder, EventLoopProxy and by requiring it as a supertrait of Window and ActiveEventLoop. It is especially useful for downstream consumers to be able to know that Window is Debug.
madsmtm
added
S - api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly implement
DebugforEventLoop,EventLoopBuilderandEventLoopProxy, and require it as a supertrait ofWindowandActiveEventLoop.It is especially useful for users to be able to know that
WindowisDebug(this allows them to easily make theirAppStateDebugtoo, which they could before #3857).