fix: invalidate key_pair cache instead of setting directly#489
Open
21pages wants to merge 1 commit intorustdesk:mainfrom
Open
fix: invalidate key_pair cache instead of setting directly#48921pages wants to merge 1 commit intorustdesk:mainfrom
21pages wants to merge 1 commit intorustdesk:mainfrom
Conversation
21pages
force-pushed
the
fix_key_pair_set
branch
from
f0eec6a to
32dbe2f
Compare
21pages
force-pushed
the
fix_key_pair_set
branch
from
32dbe2f to
0776d01
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes macOS key-pair caching behavior when updating Config, preventing an empty key_pair from being cached and blocking regeneration/loading (per #484).
Changes:
- Drops the
CONFIGwrite lock before touchingKEY_PAIRto avoid lock-ordering issues. - Replaces direct
KEY_PAIRcache assignment with a helper that invalidates the cache when the key pair changes (macOS only). - Adds inline documentation explaining why the cache is cleared (set to
None) instead of caching an empty key pair.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: 21pages <sunboeasy@gmail.com>
21pages
force-pushed
the
fix_key_pair_set
branch
from
0776d01 to
13c4fb3
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #484
Using
Noneinstead ofSome(key_pair)when updating the cache. If the incoming key_pair is empty,Some(key_pair)would cache the empty value andget_key_pair()would always return it without regenerating or loading.