Skip to content

Conversation

@shinmao
Copy link
Contributor

@shinmao shinmao commented Dec 30, 2025

No description provided.

@djc
Copy link
Contributor

djc commented Dec 30, 2025

@Byron are you okay with having this published as an advisory?

@Byron
Copy link
Contributor

Byron commented Dec 30, 2025

If we do that, downstream CI would light up without recurse, something I'd like to avoid if possible. The ultimate decision I happily leave to you, but if possible, this PR could wait for GitoxideLabs/gitoxide#2306 and a new release with the fix.

I should get to it tomorrow.

@djc
Copy link
Contributor

djc commented Dec 30, 2025

Oh sure, happy to wait until tomorrow.

@Byron
Copy link
Contributor

Byron commented Dec 31, 2025

With GitoxideLabs/gitoxide#2306 about to merge, it's clear that (unfortunately) the fix is a breaking change (that will probably affect no-one).
Thus, it should suffice to consider gix-date >= v0.12 as fixed, which I might just make available today as an extra release of gitoxide.

There are a couple more PRs to look at and merge before that happens though, so I think it's fair to either wait till tomorrow, or wait for my message here later today (assuming I don't forget which is a possibility).

@Byron
Copy link
Contributor

Byron commented Dec 31, 2025

Oh, and I remember that it's possible to subscribe to this discussion which triggers a notification once the top-level gitoxide crate was released.

@djc
Copy link
Contributor

djc commented Jan 4, 2026

@shinmao can you update this with the patched version 0.12? (And squash your commits.)

@shinmao
Copy link
Contributor Author

shinmao commented Jan 4, 2026

@djc done. Thanks!

@djc djc merged commit 8db93cb into rustsec:main Jan 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants