-
Notifications
You must be signed in to change notification settings - Fork 0
feat: asn support / use const functions #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
dc6dd14
7b37411
9e47ec6
19cf4e7
3fd62e7
045bb2e
02c4fda
bc9cd6f
0a99ca8
5ad13db
7669cab
7380e88
d4a8723
5c96881
7d16b04
5c0731e
0663d26
6cf94fc
720faa1
16e3d1b
40eac95
19e3465
754955f
ba07de2
ecefd98
bcea160
5794e4a
1867bf5
c660dff
c13791a
bbfeab1
d38c3d4
43808e9
1a29455
a44a439
d41e674
0e9b0f1
833983e
67556c2
23f751c
fcac56f
d159fb1
6c0aa24
e84382b
c87bd7d
2ae63f0
2f0ef78
51ca6a8
5bbcff5
e0a86a4
a6b3ce1
8783f57
ea29d49
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| cognitive-complexity-threshold = 15 | ||
| cognitive-complexity-threshold = 20 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Increasing the cognitive complexity threshold from 15 to 20 can hide functions that are becoming overly complex. It's often better to refactor such functions to reduce their complexity rather than relaxing the lint. Could you provide some context on which function(s) necessitated this change? It might be an opportunity for a beneficial refactoring. |
||
|
|
||
| disallowed-names = [ | ||
| "bool", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| name: Rust CI | ||
|
|
||
| on: | ||
| push: | ||
| pull_request: | ||
|
|
||
| env: | ||
| CARGO_TERM_COLOR: always | ||
|
|
||
| jobs: | ||
| build: | ||
| name: Build & Test # Consider renaming to "Check" if only cargo check is run | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Install Rust toolchain | ||
| uses: dtolnay/rust-toolchain@stable | ||
| # No specific components needed if only cargo check is run, | ||
| # but keeping rustfmt and clippy doesn't hurt for future use. | ||
| with: | ||
| components: clippy, rustfmt | ||
|
|
||
| - name: Cache Cargo dependencies | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: | | ||
| ~/.cargo/bin/ | ||
| ~/.cargo/registry/index/ | ||
| ~/.cargo/registry/cache/ | ||
| ~/.cargo/git/db/ | ||
| target/ | ||
|
|
||
| key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-cargo-packages | ||
|
|
||
| - name: Run Cargo Check | ||
| run: cargo check --all-targets --all-features --workspace | ||
|
|
||
| - name: Check formatting | ||
| run: cargo fmt --all -- --check | ||
|
|
||
| - name: Run Clippy | ||
| run: cargo clippy --all-targets --all-features --workspace |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,7 +21,7 @@ | |
| - **Maintain disciplined scope** - Execute only ordered tasks; avoid scope creep that can introduce instability | ||
| - **Auto commit and push after each individual task is done.** | ||
| - **NEVER use --no-verify when committing. Instead, fix the issues properly instead of bypassing the pre-commit hooks.** | ||
| - **Always look for @docs/external-libraries/ when implementing APIs or designing exchange abstractions.** | ||
| - **Always look for @docs/external-libraries/ and @docs/fix-specs/ when implementing APIs or designing exchange abstractions.** | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
metaphorics marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - **Periodically renew `TODO.md` for saving current progress and updating the pending tasks.** | ||
|
|
||
| --- | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,16 +12,22 @@ members = [ | |
| resolver = "2" | ||
|
|
||
| [workspace.package] | ||
| authors = ["cognitive-glitch", "Team Rusty Trading", "Filippo Neysofu Costa"] | ||
| version = "0.7.3" | ||
| authors = ["cognitive-glitch", "Rusty Trading Team", "Filippo Neysofu Costa"] | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| version = "0.7.4" | ||
| edition = "2024" | ||
| homepage = "https://github.com/rusty-trading/rusty-fix-engine" | ||
| repository = "https://github.com/rusty-trading/rusty-fix-engine" | ||
| description = "FIX & FAST (FIX Adapted for STreaming) in pure Rust" | ||
| publish = true | ||
| readme = "README.md" | ||
| keywords = ["fix", "fast", "protocol", "finance", "fintech"] | ||
| categories = ["network-programming", "parser-implementations", "encoding"] | ||
| keywords = ["fix", "fix-protocol", "fast", "trading", "hft"] | ||
| categories = [ | ||
| "network-programming", | ||
| "parser-implementations", | ||
| "encoding", | ||
| "finance", | ||
| "development-tools", | ||
| ] | ||
| license = "Apache-2.0" | ||
|
|
||
| # Workspace-wide linting configuration | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cognitive complexity threshold has been increased from 15 to 20. While this can be necessary sometimes, it might also indicate that some functions are becoming too complex and should be refactored. For instance,
generate_field_value_enumsincrates/rustyasn/build.rsis quite complex. It might be better to break down such functions into smaller, more manageable pieces rather than increasing the threshold. This will improve long-term maintainability.