Skip to content

Update waveforms_dashboard.dart#38

Open
StevenJGreen wants to merge 1 commit intorutvik110:masterfrom
StevenJGreen:Updates-for-greater-than-audioplayers-v1.0.1
Open

Update waveforms_dashboard.dart#38
StevenJGreen wants to merge 1 commit intorutvik110:masterfrom
StevenJGreen:Updates-for-greater-than-audioplayers-v1.0.1

Conversation

@StevenJGreen
Copy link
Contributor

Modified the code to work with versions of audioplayers greater than audioplayers-v1.0.1

Modified the code to work with versions of audioplayers greater than audioplayers-v1.0.1
@rutvik110
Copy link
Owner

hey Steven, I checked out your patch but I'm getting compile time errors in the example folder? Seems like the issue's due to using older version of audioplayers plugin in pubspec where as changes you made are using the latest api from v1.0.1 .

@StevenJGreen
Copy link
Contributor Author

StevenJGreen commented Jun 25, 2023 via email

@rutvik110
Copy link
Owner

Yes, that would be needed.

Btw, how did you made the changes in the first place if the version in pubspec wasn't updated to use latest audioplayers plugin api?

@StevenJGreen
Copy link
Contributor Author

StevenJGreen commented Jun 25, 2023 via email

@rutvik110
Copy link
Owner

Could you please update in pubspec as well?

Also one another thing, beside the waveforms_dashboard, the example in the main.dart doesn't seem to be using the latest audioplayers plugin as you're doing in waveforms_dashboard. So if you're updating audioplayers to latest version, please make sure to update that example as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants