Open
Conversation
Modified the code to work with versions of audioplayers greater than audioplayers-v1.0.1
Owner
|
hey Steven, I checked out your patch but I'm getting compile time errors in the |
Contributor
Author
|
hey
Should I update your pubspec as well ?
…On Sun, 25 Jun 2023 at 06:47, Rutvik Tak ***@***.***> wrote:
hey Steven, I checked out your patch but I'm getting compile time errors
in the example folder? Seems like the issue's due to using older version
of audioplayers plugin in pubspec where as changes you made are using the
latest api from v1.0.1 .
—
Reply to this email directly, view it on GitHub
<#38 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2OV2WY67ITUJN3KWD6R7TXM67H3ANCNFSM6AAAAAAZSVS6LU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Owner
|
Yes, that would be needed. Btw, how did you made the changes in the first place if the version in |
Contributor
Author
|
I updated it locally I didn’t include it in the pull request.
…On Sun, 25 Jun 2023 at 09:52, Rutvik Tak ***@***.***> wrote:
Yes, that would be needed.
Btw, how did you made the changes in the first place if the version in
pubspec wasn't updated to use latest audioplayers plugin api?
—
Reply to this email directly, view it on GitHub
<#38 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2OV2S2NTT2NTM7LUCNMQDXM7U4TANCNFSM6AAAAAAZSVS6LU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Owner
|
Could you please update in Also one another thing, beside the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified the code to work with versions of audioplayers greater than audioplayers-v1.0.1