fix: resolve 5 P0 critical issues + pre-existing compile errors#239
Merged
fix: resolve 5 P0 critical issues + pre-existing compile errors#239
Conversation
- ONNX embeddings: dynamic dimension detection + conditional token_type_ids (#237) - rvf-node: add compression field pass-through to Rust N-API struct (#225) - Cargo workspace: add glob excludes for nested rvf sub-packages (#214) - ruvllm: fix stats crash (null guard + try/catch) + generate warning (#103) - ruvllm-wasm: deprecated placeholder on npm (#238) - Pre-existing: fix ruvector-sparse-inference-wasm API mismatch, exclude from workspace - Pre-existing: fix ruvector-cloudrun-gpu RuvectorLayer::new() Result handling Co-Authored-By: claude-flow <ruv@ruv.net>
This was referenced Mar 6, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
token_type_idsonly when model expects itcompressionfield to Rust N-APIRvfOptionsstruct +parse_compression()helper"crates/rvf/*"and"crates/rvf/*/*"glob excludesllm.stats(), nullish coalescing on all property accesses; added experimental inference warning togenerate@ruvector/ruvllm-wasm@0.1.0on npmPre-existing fixes
ruvector-sparse-inference-wasm: Rewrote lib.rs to match current core API, excluded from workspace members (WASM-only target)ruvector-cloudrun-gpu: FixedRuvectorLayer::new()which now returnsResult— added.expect()Test plan
cargo check— 0 errors across full workspacecargo test --workspace— all tests passnpm test— 69/69 passcargo check -p rvf-node— compiles cleancargo metadata— both workspaces resolveCloses #237, #225, #214, #103, #238
🤖 Generated with claude-flow