Skip to content

Upgrade GitHub Actions for Node 24 compatibility #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
salmanmkc wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upgrade GitHub Actions for Node 24 compatibility #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions .github/workflows/agentic-synth-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
fetch-depth: 0

- name: Setup Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@v6
with:
node-version: ${{ env.NODE_VERSION }}
cache: 'npm'
Expand Down Expand Up @@ -81,10 +81,10 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: Setup Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
uses: actions/setup-node@v6
with:
node-version: ${{ matrix.node-version }}
cache: 'npm'
Expand Down Expand Up @@ -131,7 +131,7 @@ jobs:

- name: Upload build artifacts
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '20.x'
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v6
with:
name: build-artifacts
path: |
Expand All @@ -147,10 +147,10 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: Setup Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@v6
with:
node-version: ${{ env.NODE_VERSION }}
cache: 'npm'
Expand Down Expand Up @@ -191,10 +191,10 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: Setup Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@v6
with:
node-version: ${{ env.NODE_VERSION }}
cache: 'npm'
Expand All @@ -213,7 +213,7 @@ jobs:
run: npm run benchmark || echo "Benchmarks completed"

- name: Upload benchmark results
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v6
with:
name: benchmark-results
path: ${{ env.PACKAGE_PATH }}/benchmarks/results/
Expand All @@ -227,10 +227,10 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: Setup Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@v6
with:
node-version: ${{ env.NODE_VERSION }}

Expand All @@ -252,10 +252,10 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: Setup Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@v6
with:
node-version: ${{ env.NODE_VERSION }}
cache: 'npm'
Expand Down Expand Up @@ -303,7 +303,7 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: Check required documentation
working-directory: ${{ env.PACKAGE_PATH }}
Expand Down
22 changes: 11 additions & 11 deletions .github/workflows/benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: Install Rust toolchain
uses: actions-rs/toolchain@v1
Expand All @@ -43,23 +43,23 @@ jobs:
override: true

- name: Cache cargo registry
uses: actions/cache@v4
uses: actions/cache@v5
with:
path: ~/.cargo/registry
key: ${{ runner.os }}-cargo-registry-${{ hashFiles('**/Cargo.lock') }}
restore-keys: |
${{ runner.os }}-cargo-registry-

- name: Cache cargo index
uses: actions/cache@v4
uses: actions/cache@v5
with:
path: ~/.cargo/git
key: ${{ runner.os }}-cargo-git-${{ hashFiles('**/Cargo.lock') }}
restore-keys: |
${{ runner.os }}-cargo-git-

- name: Cache cargo build
uses: actions/cache@v4
uses: actions/cache@v5
with:
path: target
key: ${{ runner.os }}-cargo-build-benchmarks-${{ hashFiles('**/Cargo.lock') }}
Expand Down Expand Up @@ -105,7 +105,7 @@ jobs:
cargo bench --features pg17 --bench quantized_distance_bench -- --output-format bencher | tee ../../quantized_distance_bench.txt

- name: Upload benchmark results
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v6
with:
name: benchmark-results
path: |
Expand Down Expand Up @@ -157,7 +157,7 @@ jobs:
- name: Comment PR with results
if: github.event_name == 'pull_request'
continue-on-error: true
uses: actions/github-script@v7
uses: actions/github-script@v8
with:
script: |
const fs = require('fs');
Expand Down Expand Up @@ -192,7 +192,7 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: Install Rust toolchain
uses: actions-rs/toolchain@v1
Expand Down Expand Up @@ -254,7 +254,7 @@ jobs:
psql -f benches/sql/benchmark_workload.sql | tee ../../sql_workload_bench.txt

- name: Upload SQL benchmark results
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v6
with:
name: sql-benchmark-results
path: |
Expand All @@ -270,12 +270,12 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
fetch-depth: 0

- name: Download current benchmarks
uses: actions/download-artifact@v4
uses: actions/download-artifact@v7
with:
name: benchmark-results
path: current
Expand Down Expand Up @@ -329,7 +329,7 @@ jobs:

- name: Comment comparison
continue-on-error: true
uses: actions/github-script@v7
uses: actions/github-script@v8
with:
script: |
const fs = require('fs');
Expand Down
20 changes: 10 additions & 10 deletions .github/workflows/build-attention.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,10 @@ jobs:
runs-on: ${{ matrix.settings.host }}

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

- name: Setup Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@v6
with:
node-version: '20'

Expand Down Expand Up @@ -150,7 +150,7 @@ jobs:
"

- name: Upload artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v6
with:
name: attention-${{ matrix.settings.platform }}
path: crates/ruvector-attention-node/npm/${{ matrix.settings.platform }}/*.node
Expand All @@ -161,7 +161,7 @@ jobs:
runs-on: ubuntu-22.04

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

- name: Setup Rust
uses: dtolnay/rust-toolchain@stable
Expand All @@ -185,7 +185,7 @@ jobs:
run: ls -la crates/ruvector-attention-wasm/pkg/

- name: Upload WASM artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v6
with:
name: attention-wasm
path: crates/ruvector-attention-wasm/pkg/
Expand All @@ -200,12 +200,12 @@ jobs:
contents: write

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
ref: ${{ github.head_ref || github.ref_name }}

- name: Download all artifacts
uses: actions/download-artifact@v4
uses: actions/download-artifact@v7
with:
path: artifacts

Expand Down Expand Up @@ -265,16 +265,16 @@ jobs:
if: startsWith(github.ref, 'refs/tags/v')

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

- name: Setup Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@v6
with:
node-version: '20'
registry-url: 'https://registry.npmjs.org'

- name: Download all artifacts
uses: actions/download-artifact@v4
uses: actions/download-artifact@v7
with:
path: artifacts

Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/build-gnn.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,10 @@ jobs:
runs-on: ${{ matrix.settings.host }}

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

- name: Setup Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@v6
with:
node-version: '18'

Expand Down Expand Up @@ -110,7 +110,7 @@ jobs:
cp -v "$NODE_FILE" "gnn-artifacts/${{ matrix.settings.platform }}/"

- name: Upload artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v6
with:
name: gnn-bindings-${{ matrix.settings.platform }}
path: gnn-artifacts/${{ matrix.settings.platform }}/*.node
Expand All @@ -125,16 +125,16 @@ jobs:
startsWith(github.ref, 'refs/tags/v')

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

- name: Setup Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@v6
with:
node-version: '18'
registry-url: 'https://registry.npmjs.org'

- name: Download all artifacts
uses: actions/download-artifact@v4
uses: actions/download-artifact@v7
with:
path: artifacts

Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/build-graph-node.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,10 @@ jobs:
runs-on: ${{ matrix.settings.host }}

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

- name: Setup Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@v6
with:
node-version: '18'

Expand Down Expand Up @@ -118,7 +118,7 @@ jobs:
run: npm test

- name: Upload artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v6
with:
name: graph-node-${{ matrix.settings.platform }}
path: graph-artifacts/${{ matrix.settings.platform }}/*.node
Expand All @@ -131,16 +131,16 @@ jobs:
if: inputs.publish == true || startsWith(github.ref, 'refs/tags/v')

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

- name: Setup Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@v6
with:
node-version: '18'
registry-url: 'https://registry.npmjs.org'

- name: Download all artifacts
uses: actions/download-artifact@v4
uses: actions/download-artifact@v7
with:
path: artifacts

Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/build-native.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,10 @@ jobs:
runs-on: ${{ matrix.settings.host }}

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

- name: Setup Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@v6
with:
node-version: '18'

Expand Down Expand Up @@ -165,7 +165,7 @@ jobs:
fi

- name: Upload artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v6
with:
name: bindings-${{ matrix.settings.platform }}
path: npm/core/platforms/${{ matrix.settings.platform }}/*.node
Expand All @@ -185,12 +185,12 @@ jobs:
contents: write

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
ref: ${{ github.head_ref || github.ref_name }}

- name: Download all artifacts
uses: actions/download-artifact@v4
uses: actions/download-artifact@v7
with:
path: artifacts

Expand Down
Loading