Added prettier #115
Open
Added prettier #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I'm not familiar with ts-standard unfortunately, I welcome your input on that though. A shame about the .editorconfig options, but maybe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @rvagg, I know that in #108 we said to add a
.editorconfigfile, but sadly its options are limited for Javascript (for example, semi-colons). So I opted in for prettier to achieve better results.I hope this will be still appreciated!
Let me know!
EDIT: Oh, I'm seeing right now that this seems to conflict with Standardjs checks 😳.
It seems that it would be required to use
ts-standardto format in the same way also typescript declarations 🤔 What should I do with this PR? Keep it, change tots-standardo what else?