Open
Conversation
A simple but effective interface to create draw image command in order to draw custom content inside a rect
|
It might also be useful to add an additional ID parameter to the command so that it can be used to distinguish between different kinds of images without requiring multiple commands. |
ccawley2011
reviewed
Aug 20, 2025
Comment on lines
+478
to
+479
| rect = intersect_rects(rect, mu_get_clip_rect(ctx)); | ||
| if (rect.w > 0 && rect.h > 0) { |
There was a problem hiding this comment.
This looks like it'll scale the image rather than clipping it. You'll probably want something closer to how mu_draw_text and mu_draw_icon handles clipping.
Author
There was a problem hiding this comment.
Yes, maybe it would be better to remove the line 478 in order to specify with rect the exact dimensions of framebuffer
|
there has been a new community fork of this repository. the community is looking to add some new simple features. please feel free to try your PR over there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple but effective interface to create a draw image command, allowing custom content to be rendered inside a rectangle.
While working on a personal project with this library, I felt the need to render custom content on the screen—such as a texture stored in a framebuffer—without losing the benefits of the layout system provided by the library. To achieve this, I introduced the
mu_draw_imagefunction, which essentially extendsmu_draw_rectby accepting a pointer to a framebuffer for the image instead of a solid color.Alongside this, the
mu_ImageCommandwas added to store the necessary data, together with theMU_COMMAND_IMAGEentry in the command-type enumeration.This makes it possible to forward the request to the user-provided renderer, which can then draw the custom content on the screen.
